You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/05/08 03:15:02 UTC
Review Request 21186: Added a test that ensure a recovered slave is not
removed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21186/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1319
https://issues.apache.org/jira/browse/MESOS-1319
Repository: mesos-git
Description
-------
This tests that when a recovered slave re-registers with the master, the master does not remove the slave after the re-registration timeout.
Rather than expecting the registry to remain the same, this ensures the "lost" signal is not sent to the scheduler.
Diffs
-----
src/tests/master_tests.cpp 939a08d0ed25293d103728864c2b5e79f04a1b42
Diff: https://reviews.apache.org/r/21186/diff/
Testing
-------
./bin/mesos-tests.sh --gtest_filter="MasterTest.RecoveredSlaveReregisters" --gtest_repeat=200 --gtest_break_on_failu --verbose
Thanks,
Ben Mahler
Re: Review Request 21186: Added a test that ensure a recovered slave is not
removed.
Posted by Vinod Kone <vi...@gmail.com>.
> On May 8, 2014, 5:55 p.m., Vinod Kone wrote:
> >
Title: s/ensure/ensures/ ?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21186/#review42516
-----------------------------------------------------------
On May 8, 2014, 1:15 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21186/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 1:15 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1319
> https://issues.apache.org/jira/browse/MESOS-1319
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This tests that when a recovered slave re-registers with the master, the master does not remove the slave after the re-registration timeout.
>
> Rather than expecting the registry to remain the same, this ensures the "lost" signal is not sent to the scheduler.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 939a08d0ed25293d103728864c2b5e79f04a1b42
>
> Diff: https://reviews.apache.org/r/21186/diff/
>
>
> Testing
> -------
>
> ./bin/mesos-tests.sh --gtest_filter="MasterTest.RecoveredSlaveReregisters" --gtest_repeat=200 --gtest_break_on_failu --verbose
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 21186: Added a test that ensure a recovered slave is not
removed.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21186/#review42516
-----------------------------------------------------------
Ship it!
src/tests/master_tests.cpp
<https://reviews.apache.org/r/21186/#comment76307>
s/Re-start/Restart/
- Vinod Kone
On May 8, 2014, 1:15 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21186/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 1:15 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1319
> https://issues.apache.org/jira/browse/MESOS-1319
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This tests that when a recovered slave re-registers with the master, the master does not remove the slave after the re-registration timeout.
>
> Rather than expecting the registry to remain the same, this ensures the "lost" signal is not sent to the scheduler.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 939a08d0ed25293d103728864c2b5e79f04a1b42
>
> Diff: https://reviews.apache.org/r/21186/diff/
>
>
> Testing
> -------
>
> ./bin/mesos-tests.sh --gtest_filter="MasterTest.RecoveredSlaveReregisters" --gtest_repeat=200 --gtest_break_on_failu --verbose
>
>
> Thanks,
>
> Ben Mahler
>
>