[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #5874: [MINOR]: Refactor to increase readability

["comphead (via GitHub)" <gi...@apache.org>]

comphead commented on code in PR #5874:
URL: https://github.com/apache/arrow-datafusion/pull/5874#discussion_r1158650954


##########
datafusion/common/src/utils.rs:
##########
@@ -162,6 +163,23 @@ where
     Ok(low)
 }
 
+/// This function finds the partition points according to `partition_columns`.
+/// If there are no sort columns, then the result will be a single element
+/// vector containing one partition range spanning all data.
+pub fn evaluate_partition_points(

Review Comment:
   Cool, thanks. Some nit: maybe we can invent better naming for `evaluation_partition_points` Partition point I found definitions in Informatica system, not sure if its the same we calculate here. 
   
   Also method returns `lexicographical_partition_ranges` so maybe we can name method similar.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org