[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #12233: [Fix#12231][scheduler-plugin] fix the bug which some scheduled tasks are not triggered on time.

[GitBox <gi...@apache.org>]

ruanwenjun commented on code in PR #12233:
URL: https://github.com/apache/dolphinscheduler/pull/12233#discussion_r990894116


##########
dolphinscheduler-scheduler-plugin/dolphinscheduler-scheduler-quartz/src/main/java/org/apache/dolphinscheduler/scheduler/quartz/QuartzScheduler.java:
##########
@@ -111,7 +111,7 @@ public void insertOrUpdateScheduleTask(int projectId, Schedule schedule) throws
                     .endAt(endDate)
                     .withSchedule(
                             cronSchedule(cronExpression)
-                                    .withMisfireHandlingInstructionDoNothing()
+                                    .withMisfireHandlingInstructionFireAndProceed()

Review Comment:
   Good catch, we miss this.
   
   This parameter works with `org.quartz.jobStore.misfireThreshold`, can we make this configurable? Maybe some user don't want to open this.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org