You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/06/25 12:12:20 UTC

[GitHub] [hive] szlta opened a new pull request #2428: HIVE-25287

szlta opened a new pull request #2428:
URL: https://github.com/apache/hive/pull/2428


   NPE is thrown upon inserting values into an Iceberg table, as statistics generation triggers an alter table operation with undefined (alter)operation type


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] szlta merged pull request #2428: HIVE-25287

Posted by GitBox <gi...@apache.org>.
szlta merged pull request #2428:
URL: https://github.com/apache/hive/pull/2428


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] pvary commented on a change in pull request #2428: HIVE-25287

Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #2428:
URL: https://github.com/apache/hive/pull/2428#discussion_r658727472



##########
File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -288,7 +288,7 @@ public void commitAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable
           break;
         case ADDPROPS:
         case DROPPROPS:
-          alterTableProperties(hmsTable, context.getProperties());
+          alterTableProperties(hmsTable, contextProperties);

Review comment:
       Do we need this `contextProperties` variable?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org