You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/06 09:32:28 UTC
[GitHub] [skywalking-docker] andrewgkew opened a new pull request #23: Improved docker compose file so can be run for ES6 and ES7
andrewgkew opened a new pull request #23:
URL: https://github.com/apache/skywalking-docker/pull/23
1. Updated compose file to include the SW_STORAGE env var otherwise it cant be overwritten when which between ES6 and ES7
2. Add missing env var SW_VERSION into env files
3. Updated versions of ES and SW to latest versions for both ES6 and ES7
This has been tested on docker Docker version 20.10.8, build 3967b7d on Ubuntu 18.04
And without the SW_STORAGE var added to compose file when running using the .env.es7 env file the OAP container fails, and without SW_VERSION the docker compose command does not work (you could pass it into the command but this seems cleaner)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] andrewgkew commented on pull request #23: Improved docker compose file so can be run for ES6 and ES7
Posted by GitBox <gi...@apache.org>.
andrewgkew commented on pull request #23:
URL: https://github.com/apache/skywalking-docker/pull/23#issuecomment-894154246
> Are you talking about pulling the images from https://www.docker.elastic.co/
>
> i.e docker.elastic.co/elasticsearch/elasticsearch
>
> The images are available on DockerHub using Elastic License 2.0
>
> DIdnt realize about the SSPL licence will look into that.
>
> I am happy to adjust the compose file to use dockerhub images instead if thats what you are saying?
Just seen in your docs that the licence is as of version 7.11
This license change is effective from Elasticsearch version 7.11.
So can adjust the versions accordingly so that they dont clash with Apache licence
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] andrewgkew commented on pull request #23: Improved docker compose file so can be run for ES6 and ES7
Posted by GitBox <gi...@apache.org>.
andrewgkew commented on pull request #23:
URL: https://github.com/apache/skywalking-docker/pull/23#issuecomment-894136694
Agreed version upgrade is not required, but thought I would do it while I was making this change. Happy to remove that change from the functional change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] andrewgkew commented on pull request #23: Improved docker compose file so can be run for ES6 and ES7
Posted by GitBox <gi...@apache.org>.
andrewgkew commented on pull request #23:
URL: https://github.com/apache/skywalking-docker/pull/23#issuecomment-894154577
> SSPL does not relate to docker, it affects the binary.
> https://skywalking.apache.org/docs/main/v8.7.0/en/setup/backend/backend-storage/#elasticsearch
>
> 7.10 is the last Apache 2.0 licensed binary. I didn'tcheck ElasticSearch 6, but I think there is a red line.
Yup just seen that on your docs. Makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] wu-sheng commented on pull request #23: Improved docker compose file so can be run for ES6 and ES7
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #23:
URL: https://github.com/apache/skywalking-docker/pull/23#issuecomment-894163381
We need a check on ElasticSearch 6. I think we can't use latest too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] wu-sheng commented on pull request #23: Improved docker compose file so can be run for ES6 and ES7
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #23:
URL: https://github.com/apache/skywalking-docker/pull/23#issuecomment-894135837
It is fine to upgrade ES server version for testing. But it seems to be not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] wu-sheng commented on pull request #23: Improved docker compose file so can be run for ES6 and ES7
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #23:
URL: https://github.com/apache/skywalking-docker/pull/23#issuecomment-894153953
SSPL does not relate to docker, it affects the binary.
https://skywalking.apache.org/docs/main/v8.7.0/en/setup/backend/backend-storage/#elasticsearch
7.10 is the last Apache 2.0 licensed binary. I didn'tcheck ElasticSearch 6, but I think there is a red line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] andrewgkew commented on a change in pull request #23: Improved docker compose file so can be run for ES6 and ES7
Posted by GitBox <gi...@apache.org>.
andrewgkew commented on a change in pull request #23:
URL: https://github.com/apache/skywalking-docker/pull/23#discussion_r684215301
##########
File path: compose/.env.es6
##########
@@ -14,6 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ES_VERSION=6.8.8
+ES_VERSION=6.8.18
SW_STORAGE=elasticsearch
IMAGE_TAG=es6
+SW_VERSION=8.7.0
Review comment:
Makes sense. Have pushed a change removing SW_VERSION
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] JaredTan95 merged pull request #23: Improved docker compose file so can be run for ES6 and ES7
Posted by GitBox <gi...@apache.org>.
JaredTan95 merged pull request #23:
URL: https://github.com/apache/skywalking-docker/pull/23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] andrewgkew commented on pull request #23: Improved docker compose file so can be run for ES6 and ES7
Posted by GitBox <gi...@apache.org>.
andrewgkew commented on pull request #23:
URL: https://github.com/apache/skywalking-docker/pull/23#issuecomment-894151478
Are you talking about pulling the images from https://www.docker.elastic.co/
i.e docker.elastic.co/elasticsearch/elasticsearch
The images are available on DockerHub using Elastic License 2.0
DIdnt realize about the SSPL licence will look into that.
I am happy to adjust the compose file to use dockerhub images instead if thats what you are saying?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] JaredTan95 commented on a change in pull request #23: Improved docker compose file so can be run for ES6 and ES7
Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on a change in pull request #23:
URL: https://github.com/apache/skywalking-docker/pull/23#discussion_r684131103
##########
File path: compose/.env.es6
##########
@@ -14,6 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ES_VERSION=6.8.8
+ES_VERSION=6.8.18
SW_STORAGE=elasticsearch
IMAGE_TAG=es6
+SW_VERSION=8.7.0
Review comment:
we use https://github.com/apache/skywalking-docker/blob/master/8/v8.7.0.sh to export `SW_VERSION` when we dev and test. and I agree with @wu-sheng , do not harcode here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] JaredTan95 commented on a change in pull request #23: Improved docker compose file so can be run for ES6 and ES7
Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on a change in pull request #23:
URL: https://github.com/apache/skywalking-docker/pull/23#discussion_r684116443
##########
File path: compose/.env.es6
##########
@@ -14,6 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ES_VERSION=6.8.8
+ES_VERSION=6.8.18
SW_STORAGE=elasticsearch
IMAGE_TAG=es6
+SW_VERSION=8.7.0
Review comment:
`SW_VERSION` set in https://github.com/apache/skywalking-docker/blob/master/Makefile#L58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] wu-sheng commented on pull request #23: Improved docker compose file so can be run for ES6 and ES7
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #23:
URL: https://github.com/apache/skywalking-docker/pull/23#issuecomment-894148042
We don't recommend you are using ElasticSearch SSPL licensed released.
Take a lool at SkyWalking main repo storage doc, we shared with you this, and indicated the latest Apache 2.0 releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] wu-sheng commented on a change in pull request #23: Improved docker compose file so can be run for ES6 and ES7
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #23:
URL: https://github.com/apache/skywalking-docker/pull/23#discussion_r684218029
##########
File path: compose/.env.es7
##########
@@ -14,6 +14,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ES_VERSION=7.5.0
+ES_VERSION=7.10.0
Review comment:
https://github.com/elastic/elasticsearch/blob/v7.10.2/LICENSE.txt 7.10.2 is the last 7.x Apache 2.0 release.
##########
File path: compose/.env.es6
##########
@@ -14,6 +14,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ES_VERSION=6.8.8
+ES_VERSION=6.8.18
Review comment:
Confirmed, https://github.com/elastic/elasticsearch/blob/v6.8.18/LICENSE.txt 6.8.18 is still Apache 2.0 License.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] wu-sheng commented on pull request #23: Improved docker compose file so can be run for ES6 and ES7
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #23:
URL: https://github.com/apache/skywalking-docker/pull/23#issuecomment-894148494
If you want to upgrade, should be stopped at there. Elastic forces ASF community has to stop at there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] andrewgkew commented on a change in pull request #23: Improved docker compose file so can be run for ES6 and ES7
Posted by GitBox <gi...@apache.org>.
andrewgkew commented on a change in pull request #23:
URL: https://github.com/apache/skywalking-docker/pull/23#discussion_r684118545
##########
File path: compose/.env.es6
##########
@@ -14,6 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ES_VERSION=6.8.8
+ES_VERSION=6.8.18
SW_STORAGE=elasticsearch
IMAGE_TAG=es6
+SW_VERSION=8.7.0
Review comment:
I was using the docker compose files by themselves not using make. But that makes sense (no pun instead)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] wu-sheng commented on a change in pull request #23: Improved docker compose file so can be run for ES6 and ES7
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #23:
URL: https://github.com/apache/skywalking-docker/pull/23#discussion_r684127614
##########
File path: compose/.env.es6
##########
@@ -14,6 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ES_VERSION=6.8.8
+ES_VERSION=6.8.18
SW_STORAGE=elasticsearch
IMAGE_TAG=es6
+SW_VERSION=8.7.0
Review comment:
It is better to update doc about this env. We don't recommend hardcode version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org