You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Ke Jia <ke...@intel.com> on 2016/07/13 05:08:54 UTC
Review Request 49976: SENTRY-1401 In V2,
show role grant group groupname should not throw an exception if group
doesnt exist in db.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49976/
-----------------------------------------------------------
Review request for sentry and Dapeng Sun.
Bugs: SENTRY-1401
https://issues.apache.org/jira/browse/SENTRY-1401
Repository: sentry
Description
-------
In V2, show role grant group groupname should not throw an exception if group doesnt exist in db.
Diffs
-----
sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 0012a8a
Diff: https://reviews.apache.org/r/49976/diff/
Testing
-------
testing
Thanks,
Ke Jia
Re: Review Request 49976: SENTRY-1401 In V2,
show role grant group groupname should not throw an exception if group
doesnt exist in db.
Posted by Ke Jia <ke...@intel.com>.
> On July 13, 2016, 5:32 a.m., Dapeng Sun wrote:
> > Better to refine TestGrantUserToRole like SENTRY-320 did.
Thanks dapeng comment. SENTRY-1402 will add the TestGrantUserToRole.java in v2. Then I will refine TestGrantUSerToRole like SENTRY-320 did.
- Ke
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49976/#review142008
-----------------------------------------------------------
On July 13, 2016, 5:08 a.m., Ke Jia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49976/
> -----------------------------------------------------------
>
> (Updated July 13, 2016, 5:08 a.m.)
>
>
> Review request for sentry and Dapeng Sun.
>
>
> Bugs: SENTRY-1401
> https://issues.apache.org/jira/browse/SENTRY-1401
>
>
> Repository: sentry
>
>
> Description
> -------
>
> In V2, show role grant group groupname should not throw an exception if group doesnt exist in db.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 0012a8a
>
> Diff: https://reviews.apache.org/r/49976/diff/
>
>
> Testing
> -------
>
> testing
>
>
> Thanks,
>
> Ke Jia
>
>
Re: Review Request 49976: SENTRY-1401 In V2,
show role grant group groupname should not throw an exception if group
doesnt exist in db.
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49976/#review142008
-----------------------------------------------------------
Better to refine TestGrantUserToRole like SENTRY-320 did.
sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java (line 2022)
<https://reviews.apache.org/r/49976/#comment207476>
I think we can delete it
- Dapeng Sun
On \u4e03\u6708 13, 2016, 1:08 p.m., Ke Jia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49976/
> -----------------------------------------------------------
>
> (Updated \u4e03\u6708 13, 2016, 1:08 p.m.)
>
>
> Review request for sentry and Dapeng Sun.
>
>
> Bugs: SENTRY-1401
> https://issues.apache.org/jira/browse/SENTRY-1401
>
>
> Repository: sentry
>
>
> Description
> -------
>
> In V2, show role grant group groupname should not throw an exception if group doesnt exist in db.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 0012a8a
>
> Diff: https://reviews.apache.org/r/49976/diff/
>
>
> Testing
> -------
>
> testing
>
>
> Thanks,
>
> Ke Jia
>
>