[jira] [Commented] (FLINK-7517) let NettyBufferPool extend PooledByteBufAllocator

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141584#comment-16141584 ] 

ASF GitHub Bot commented on FLINK-7517:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4594

    [FLINK-7517][network] let NettyBufferPool extend PooledByteBufAllocator

    ## What is the purpose of the change
    
    `NettyBufferPool` wraps `PooledByteBufAllocator` but due to this, any allocated buffer's `alloc()` method is returning the wrapped `PooledByteBufAllocator` which allows heap buffers again. By extending the `PooledByteBufAllocator` instead, we prevent this loop hole and also fix Netty's invariant that a copy of a buffer should have the same allocator.
    
    ## Brief change log
    
    - change `NettyBufferPool` from wrapping `PooledByteBufAllocator` into extending it
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as `NettyBufferPoolTest` since the behaviour does not change.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (yes)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (JavaDocs)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-7517

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4594.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4594
    
----
commit ec0db2bedffbe67b9a5e08c577a1b74f74c061ac
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-08-23T10:04:28Z

    [FLINK-7517][network] let NettyBufferPool extend PooledByteBufAllocator
    
    Previously, NettyBufferPool only wrapped PooledByteBufAllocator but then, any
    allocated buffer's alloc() method was returning the wrapped
    PooledByteBufAllocator which allowed heap buffers again. By extending the
    PooledByteBufAllocator, we prevent this loop hole.
    
    This also fixes the invariant that a copy of a buffer should have the same
    allocator.

----


> let NettyBufferPool extend PooledByteBufAllocator
> -------------------------------------------------
>
>                 Key: FLINK-7517
>                 URL: https://issues.apache.org/jira/browse/FLINK-7517
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> {{NettyBufferPool}} wraps {{PooledByteBufAllocator}} but due to this, any allocated buffer's {{alloc()}} method is returning the wrapped {{PooledByteBufAllocator}} which allowed heap buffers again. By extending the {{PooledByteBufAllocator}}, we prevent this loop hole and also fix the invariant that a copy of a buffer should have the same allocator.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)