You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org> on 2020/11/02 17:48:54 UTC
[Impala-ASF-CR] IMPALA-10306: [DOCS] add note about TZ offset
Shajini Thayasingh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16689
Change subject: IMPALA-10306: [DOCS] add note about TZ offset
......................................................................
IMPALA-10306: [DOCS] add note about TZ offset
added a note that says that TZ offset will not be included
in the output of this function even if the offset is provided as input
Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/16689/1
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list
Posted by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Gabor Kaszab, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16689
to look at the new patch set (#4).
Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
......................................................................
IMPALA-10306: [DOCS] remove TZ offset texts from the list
added an item in the list that says that TZ offset will not be included
in the output of this function even if the offset is provided as input
Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 43 insertions(+), 110 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/16689/4
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 4
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list
Posted by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Gabor Kaszab, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16689
to look at the new patch set (#2).
Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
......................................................................
IMPALA-10306: [DOCS] remove TZ offset texts from the list
added an item in the list that says that TZ offset will not be included
in the output of this function even if the offset is provided as input
Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 45 insertions(+), 88 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/16689/2
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-10306: [DOCS] remove the commented out text
Posted by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Gabor Kaszab, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16689
to look at the new patch set (#3).
Change subject: IMPALA-10306: [DOCS] remove the commented out text
......................................................................
IMPALA-10306: [DOCS] remove the commented out text
added an item in the list that says that TZ offset will not be included
in the output of this function even if the offset is provided as input
Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 43 insertions(+), 110 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/16689/3
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-10306: [DOCS] remove the commented out text
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] remove the commented out text
......................................................................
Patch Set 3:
Hi Shajini, thank you for the update.
I think when the commits were squashed the most recent commit message have been kept. Could you please update the commit message to reflect the actual change?
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Nov 2020 10:12:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 4
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Nov 2020 08:21:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
......................................................................
IMPALA-10306: [DOCS] remove TZ offset texts from the list
added an item in the list that says that TZ offset will not be included
in the output of this function even if the offset is provided as input
Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Reviewed-on: http://gerrit.cloudera.org:8080/16689
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 43 insertions(+), 110 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 6
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
......................................................................
Patch Set 2:
(1 comment)
Thanks Shajini, more note from my end.
http://gerrit.cloudera.org:8080/#/c/16689/2/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:
http://gerrit.cloudera.org:8080/#/c/16689/2/docs/topics/impala_datetime_functions.xml@1302
PS2, Line 1302: <!-- <row>
: <entry>
: <codeph>+/-hh:mm</codeph>
: </entry>
: <entry>
: Time zone offset
: </entry>
: </row>
: <row>
: <entry>
: <codeph>+/-hhmm</codeph>
: </entry>
: <entry>
: Time zone offset
: </entry>
: </row>
: <row>
: <entry>
: <codeph>+/-hh</codeph>
: </entry>
: <entry>
: Time zone offset
: </entry>
: </row>-->
This can be deleted.
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Nov 2020 13:14:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6712/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 5
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Nov 2020 08:22:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10306: [DOCS] add note about TZ offset
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] add note about TZ offset
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/606/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Nov 2020 18:09:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10306: [DOCS] remove the commented out text
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] remove the commented out text
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/608/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Nov 2020 17:31:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10306: [DOCS] add note about TZ offset
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] add note about TZ offset
......................................................................
Patch Set 1:
(3 comments)
Hi Shajini, thank you for the change.
I have left some comments inline.
http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:
http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml@1390
PS1, Line 1390: TZ
To keep the document's consistency, could you change "TZ" to "timezone".
http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml@1416
PS1, Line 1416: />
There is a similar usage note already in place here (timezone_conversion_caveat), I think the 'Usage notes' would be a better place for the new paragraph.
Also instead of <note> it could be <p>.
http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml@1420
PS1, Line 1420:
nit: empty tab
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Nov 2020 10:56:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
......................................................................
Patch Set 4: Code-Review+1
Thank Shajini, LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 4
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Nov 2020 08:20:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10306: [DOCS] add note about TZ offset
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] add note about TZ offset
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/606/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Nov 2020 17:49:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10306: [DOCS] add note about TZ offset
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] add note about TZ offset
......................................................................
Patch Set 1:
(3 comments)
Thanks for the review Gabor, I have overlooked some part of the documentation and misunderstood this change.
I commented the parts of the documentation that refer to non-existing functionalities, these could be removed.
Gabor's explanation could be part of the bulletpoints in the middle I think.
http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:
http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml@1323
PS1, Line 1323: <row>
: <entry>
: <codeph>+/-hh:mm</codeph>
: </entry>
: <entry>
: Time zone offset
: </entry>
: </row>
: <row>
: <entry>
: <codeph>+/-hhmm</codeph>
: </entry>
: <entry>
: Time zone offset
: </entry>
: </row>
: <row>
: <entry>
: <codeph>+/-hh</codeph>
: </entry>
: <entry>
: Time zone offset
: </entry>
: </row>
These formatting options will be disregarded.
http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml@1370
PS1, Line 1370: except for the time zone offset
The formatting of this timezone offset is not relevant here.
http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml@1384
PS1, Line 1384: <li>
: <codeph>yyyy-MM-dd HH:mm:ss+hh:mm</codeph>
: </li>
This part explains how to use the timezone offset, which can not be applied here.
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Nov 2020 08:15:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10306: [DOCS] add note about TZ offset
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] add note about TZ offset
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:
http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml@1416
PS1, Line 1416: />
> There is a similar usage note already in place here (timezone_conversion_ca
Shajini, if you plan to add your comment to a common place that covers all the timestamp conversion functions as Tamas suggests than please ignore my comment above about bigint inputs and such :) because that is valid only for this particular function.
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Nov 2020 16:08:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 5
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Nov 2020 08:22:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/607/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Nov 2020 17:37:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 5
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Nov 2020 13:52:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10306: [DOCS] add note about TZ offset
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] add note about TZ offset
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:
http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml@1390
PS1, Line 1390: TZ
> To keep the document's consistency, could you change "TZ" to "timezone".
I think the issues with FROM_UNIXTIME() is not that Impala doesn't store timezone information internally, but that this particular function receives a bigint number (seconds since epoch) as an input and that doesn't hold any TZ info.
This comment you wrote would be a good one for any other timstamp conversion functions that receive a timestamp and returns a formatted string.
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Nov 2020 16:06:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10306: [DOCS] remove the commented out text
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] remove the commented out text
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/608/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Nov 2020 17:38:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/607/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Nov 2020 17:46:10 +0000
Gerrit-HasComments: No