You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2011/04/06 11:13:57 UTC
DO NOT REPLY [Bug 51028] New: Build fails if Saxon 9 is on Ant's
classpath
https://issues.apache.org/bugzilla/show_bug.cgi?id=51028
Summary: Build fails if Saxon 9 is on Ant's classpath
Product: Tomcat 7
Version: trunk
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: blocker
Priority: P2
Component: Packaging
AssignedTo: dev@tomcat.apache.org
ReportedBy: 1983-01-06@gmx.net
Created an attachment (id=26860)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26860)
Build failure logfile
I am not able to build Tomcat with "ant release" because the XSL stylesheets
fail with saxon. They contain illegal chars.
If I remove Saxon from Ant's classpath the work again. So there something with
the stylesheets and Saxon.
I have found this post from Michael Kay which says that the stylesheets are
invalid and have to be fixed:
http://web.archiveorange.com/archive/v/rNJIEC48MBLYfxAORgpH
A logfile is attached too.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51028] Build fails if Saxon 9 is on Ant's
classpath
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51028
--- Comment #5 from Michael Osipov <19...@gmx.net> 2011-04-06 09:15:55 EDT ---
(In reply to comment #1)
> Which version of Tomcat7 ?
>
> I've had a look at the file in SVN and the current XSL code does not match what
> you are reporting.
>
> What does the $Id line near the top of the XSL file say?
> It should start like this:
>
> <!-- $Id: tomcat-docs.xsl
I am building from trunk.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51028] Build fails if Saxon 9 is on Ant's
classpath
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51028
Konstantin Kolinko <kn...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution| |FIXED
--- Comment #8 from Konstantin Kolinko <kn...@gmail.com> 2011-04-06 10:38:28 EDT ---
So, the bug is not in the XSLT sheet, but in the data that it was processing.
Fixed with r1089469
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51028] Build fails if Saxon 9 is on Ant's
classpath
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51028
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #1 from Sebb <se...@apache.org> 2011-04-06 07:00:33 EDT ---
Which version of Tomcat7 ?
I've had a look at the file in SVN and the current XSL code does not match what
you are reporting.
What does the $Id line near the top of the XSL file say?
It should start like this:
<!-- $Id: tomcat-docs.xsl
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51028] Build fails if Saxon 9 is on Ant's
classpath
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51028
--- Comment #4 from Michael Osipov <19...@gmx.net> 2011-04-06 09:12:04 EDT ---
(In reply to comment #2)
> Reduce severity since, assuming this issue is valid, there is a simple
> workaround (remove Saxon from Ant's classpath).
This cannot be done unless you have root priviliges on the System to modify the
global installation. Eventhough if I had, the removal would affect others.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51028] Build fails if Saxon 9 is on Ant's
classpath
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51028
--- Comment #3 from Michael Osipov <19...@gmx.net> 2011-04-06 09:11:14 EDT ---
(In reply to comment #1)
> Which version of Tomcat7 ?
>
> I've had a look at the file in SVN and the current XSL code does not match what
> you are reporting.
>
> What does the $Id line near the top of the XSL file say?
> It should start like this:
>
> <!-- $Id: tomcat-docs.xsl
SVN revision is 1089355
$Id$ of file is <!-- $Id: tomcat-docs.xsl 1036949 2010-11-19 17:18:04Z markt $
-->
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51028] Build fails if Saxon 9 is on Ant's
classpath
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51028
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|blocker |normal
--- Comment #2 from Mark Thomas <ma...@apache.org> 2011-04-06 07:07:07 EDT ---
Reduce severity since, assuming this issue is valid, there is a simple
workaround (remove Saxon from Ant's classpath).
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51028] Build fails if Saxon 9 is on Ant's
classpath
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51028
--- Comment #7 from Michael Osipov <19...@gmx.net> 2011-04-06 09:57:27 EDT ---
(In reply to comment #6)
> The relevant part of the log file says:
>
> [xslt] Processing E:\Projekte\tomcat-trunk\webapps\docs\changelog.xml to
> E:\Projekte\tomcat-trunk\output\build\webapps\docs\changelog.html
> [xslt] E:\Projekte\tomcat-trunk\webapps\docs\tomcat-docs.xsl:470: Fatal
> Error! Illegal HTML character: decimal 150
>
> Line 470 of tomcat-docs.xsl is
>
> <xsl:template match="changelog/fix">
> <tr>
> <xsl:variable name="src"><xsl:value-of
> select="$relative-path"/>/images/fix.gif</xsl:variable>
> <td><img alt="fix" class="icon" src="{$src}"/></td>
> <td><xsl:apply-templates/></td> <!-- 470 -->
> </tr>
> </xsl:template>
>
> The character 150 is clearly not present in the XSL file.
> The Saxon error message is somewhat misleading, as the invalid character seems
> to be in changelog.xml at line 1488:
>
> <bug>49428</bug>: Re-implement the fix for bug <bug>49428</bug> –
>
> Perhaps you can try temporarily editting that out, and see if that makes Saxon
> happy.
Sebb,
I removed the suspicious ref and it worked. I started digging and realized that
the document is really broken. In contrast to the built-in Xalan Saxon is not
lenient and strictly follows the specs.
The change was made by Konstantin, he doesn't seem to be encoding-savvy. If you
check the changelog.xml's encoding, you'll see UTF-8 is set in the XML prolog.
The entity ref '–' (0x96, char 'en dash')
(http://en.wikipedia.org/wiki/Dash#Common_dashes) does only exist in Windows
1252 (http://en.wikipedia.org/wiki/Windows-1252#Codepage_layout) but translated
to Unicode, this is a contol char which is forbidden in XML.
To make this work, you have to reference a valid Unicode char. In this case it
would be '–' (U+2013) see
http://www.utf8-zeichentabelle.de/unicode-utf8-table.pl?start=8192
I changed that and 'ant release' ran perfectly. I guess this is a really simple
fix in SVN and the build should work on both XSLT processors.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51028] Build fails if Saxon 9 is on Ant's
classpath
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51028
--- Comment #6 from Sebb <se...@apache.org> 2011-04-06 09:27:47 EDT ---
The relevant part of the log file says:
[xslt] Processing E:\Projekte\tomcat-trunk\webapps\docs\changelog.xml to
E:\Projekte\tomcat-trunk\output\build\webapps\docs\changelog.html
[xslt] E:\Projekte\tomcat-trunk\webapps\docs\tomcat-docs.xsl:470: Fatal
Error! Illegal HTML character: decimal 150
Line 470 of tomcat-docs.xsl is
<xsl:template match="changelog/fix">
<tr>
<xsl:variable name="src"><xsl:value-of
select="$relative-path"/>/images/fix.gif</xsl:variable>
<td><img alt="fix" class="icon" src="{$src}"/></td>
<td><xsl:apply-templates/></td> <!-- 470 -->
</tr>
</xsl:template>
The character 150 is clearly not present in the XSL file.
The Saxon error message is somewhat misleading, as the invalid character seems
to be in changelog.xml at line 1488:
<bug>49428</bug>: Re-implement the fix for bug <bug>49428</bug> –
Perhaps you can try temporarily editting that out, and see if that makes Saxon
happy.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org