[jira] [Commented] (BEAM-136) PipelineOptionsFactory should detect all runners

["Thomas Groh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202429#comment-15202429 ] 

Thomas Groh commented on BEAM-136:
----------------------------------

The default collection of runners is obtained by using ServiceLoader.load(PipelineRunnerRegistrar.class); within the SDK, we use the @AutoService annotation (com.google.auto.service.AutoService, from Guava) to register the DataflowPipelineRunner, BlockingDataflowPipelineRunner, and DirectPipelineRunner, but should automatically pick up any other registrars located on the classpath.

PR 61 (https://github.com/apache/incubator-beam/pull/61) fixes looking up runners via a fully qualified class name.

> PipelineOptionsFactory should detect all runners
> ------------------------------------------------
>
>                 Key: BEAM-136
>                 URL: https://issues.apache.org/jira/browse/BEAM-136
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Daniel Halperin
>            Assignee: Thomas Groh
>            Priority: Minor
>
> Even with flink-runner jar on classpath, we didn't find it.
> See linked thread here: http://mail-archives.apache.org/mod_mbox/incubator-beam-user/201603.mbox/%3CCAA8k_FLekCURJKYO8qab%3DR%3DG-sRrTmYc7_NQXcrY1kHyATAtBw%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)