You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/07 16:10:37 UTC

[GitHub] [beam] heidimhurst commented on a change in pull request #14869: [BEAM-12357] improve WithKeys transform to take args, kwargs

heidimhurst commented on a change in pull request #14869:
URL: https://github.com/apache/beam/pull/14869#discussion_r646739132



##########
File path: sdks/python/apache_beam/transforms/util_test.py
##########
@@ -628,6 +628,17 @@ def test_callable_k(self):
       with_keys = pc | util.WithKeys(lambda x: x * x)
     assert_that(with_keys, equal_to([(1, 1), (4, 2), (9, 3)]))
 
+  @staticmethod
+  def _test_args_kwargs_fn(x, multiply, subtract):
+    return x * multiply - subtract
+
+  def test_args_kwargs_k(self):

Review comment:
       The previous test cases test `WithKeys` for constant and callable functions, so those cases should already be covered.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org