You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@manifoldcf.apache.org by kw...@apache.org on 2013/12/10 19:31:48 UTC
svn commit: r1549923 - in /manifoldcf/trunk: CHANGES.txt
connectors/livelink/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/livelink/LivelinkConnector.java
Author: kwright
Date: Tue Dec 10 18:31:48 2013
New Revision: 1549923
URL: http://svn.apache.org/r1549923
Log:
Fix for CONNECTORS-833.
Modified:
manifoldcf/trunk/CHANGES.txt
manifoldcf/trunk/connectors/livelink/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/livelink/LivelinkConnector.java
Modified: manifoldcf/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/manifoldcf/trunk/CHANGES.txt?rev=1549923&r1=1549922&r2=1549923&view=diff
==============================================================================
--- manifoldcf/trunk/CHANGES.txt (original)
+++ manifoldcf/trunk/CHANGES.txt Tue Dec 10 18:31:48 2013
@@ -3,6 +3,9 @@ $Id$
======================= 1.5-dev =====================
+CONNECTORS-833: Fix Null Pointer exception in LiveLink connector.
+(David Morana, Karl Wright)
+
CONNECTORS-828: New stylesheet! Apparently brings the
crawler UI into the modern world.
(Eranda Bandaranaike)
Modified: manifoldcf/trunk/connectors/livelink/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/livelink/LivelinkConnector.java
URL: http://svn.apache.org/viewvc/manifoldcf/trunk/connectors/livelink/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/livelink/LivelinkConnector.java?rev=1549923&r1=1549922&r2=1549923&view=diff
==============================================================================
--- manifoldcf/trunk/connectors/livelink/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/livelink/LivelinkConnector.java (original)
+++ manifoldcf/trunk/connectors/livelink/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/livelink/LivelinkConnector.java Tue Dec 10 18:31:48 2013
@@ -95,7 +95,7 @@ public class LivelinkConnector extends o
private final static String ACTIVITY_FETCH = "fetch document";
/** Deny access token for default authority */
- private final static String defaultAuthorityDenyToken = GLOBAL_DENY_TOKEN;
+ private final static String defaultAuthorityDenyToken = "DEAD_AUTHORITY";
// Livelink does not have "deny" permissions, and there is no such thing as a document with no tokens, so it is safe to not have a local "deny" token.
// However, people feel that a suspenders-and-belt approach is called for, so this restriction has been added.
@@ -118,8 +118,7 @@ public class LivelinkConnector extends o
protected final static String GENERAL_OWNER = "general_owner";
protected final static String GENERAL_CREATOR = "general_creator";
protected final static String GENERAL_MODIFIER = "general_modifier";
- protected final static String GENERAL_PARENTID = "general_parentid";
-
+
// Signal that we have set up connection parameters properly
private boolean hasSessionParameters = false;
// Signal that we have set up a connection properly
@@ -704,16 +703,6 @@ public class LivelinkConnector extends o
}
}
}
-
- /** This method is called to assess whether to count this connector instance should
- * actually be counted as being connected.
- *@return true if the connector instance is actually connected.
- */
- @Override
- public boolean isConnected()
- {
- return hasConnected;
- }
/** Close the connection. Call this before discarding the repository connector.
*/
@@ -984,9 +973,10 @@ public class LivelinkConnector extends o
}
else if (n.getType().equals("userworkspace"))
{
- if (n.getAttributeValue("value").equals("true"))
+ String value = n.getAttributeValue("value");
+ if (value != null && value.equals("true"))
doUserWorkspaces = true;
- else if (n.getAttributeValue("value").equals("false"))
+ else if (value != null && value.equals("false"))
doUserWorkspaces = false;
}
@@ -1787,8 +1777,6 @@ public class LivelinkConnector extends o
String serverPassword = parameters.getObfuscatedParameter(LiveLinkParameters.serverPassword);
if (serverPassword == null)
serverPassword = "";
- else
- serverPassword = out.mapPasswordToKey(serverPassword);
String serverHTTPCgiPath = parameters.getParameter(LiveLinkParameters.serverHTTPCgiPath);
if (serverHTTPCgiPath == null)
serverHTTPCgiPath = "/livelink/livelink.exe";
@@ -1801,8 +1789,6 @@ public class LivelinkConnector extends o
String serverHTTPNTLMPassword = parameters.getObfuscatedParameter(LiveLinkParameters.serverHTTPNTLMPassword);
if (serverHTTPNTLMPassword == null)
serverHTTPNTLMPassword = "";
- else
- serverHTTPNTLMPassword = out.mapPasswordToKey(serverHTTPNTLMPassword);
String serverHTTPSKeystore = parameters.getParameter(LiveLinkParameters.serverHTTPSKeystore);
IKeystoreManager localServerHTTPSKeystore;
if (serverHTTPSKeystore == null)
@@ -1826,8 +1812,6 @@ public class LivelinkConnector extends o
String ingestNtlmPassword = parameters.getObfuscatedParameter(LiveLinkParameters.ingestNtlmPassword);
if (ingestNtlmPassword == null)
ingestNtlmPassword = "";
- else
- ingestNtlmPassword = out.mapPasswordToKey(ingestNtlmPassword);
String ingestNtlmDomain = parameters.getParameter(LiveLinkParameters.ingestNtlmDomain);
if (ingestNtlmDomain == null)
ingestNtlmDomain = "";
@@ -2177,7 +2161,7 @@ public class LivelinkConnector extends o
parameters.setParameter(LiveLinkParameters.serverUsername,serverUserName);
String serverPassword = variableContext.getParameter("serverpassword");
if (serverPassword != null)
- parameters.setObfuscatedParameter(LiveLinkParameters.serverPassword,variableContext.mapKeyToPassword(serverPassword));
+ parameters.setObfuscatedParameter(LiveLinkParameters.serverPassword,serverPassword);
String serverHTTPCgiPath = variableContext.getParameter("serverhttpcgipath");
if (serverHTTPCgiPath != null)
parameters.setParameter(LiveLinkParameters.serverHTTPCgiPath,serverHTTPCgiPath);
@@ -2189,7 +2173,7 @@ public class LivelinkConnector extends o
parameters.setParameter(LiveLinkParameters.serverHTTPNTLMUsername,serverHTTPNTLMUserName);
String serverHTTPNTLMPassword = variableContext.getParameter("serverhttpntlmpassword");
if (serverHTTPNTLMPassword != null)
- parameters.setObfuscatedParameter(LiveLinkParameters.serverHTTPNTLMPassword,variableContext.mapKeyToPassword(serverHTTPNTLMPassword));
+ parameters.setObfuscatedParameter(LiveLinkParameters.serverHTTPNTLMPassword,serverHTTPNTLMPassword);
String serverHTTPSKeystoreValue = variableContext.getParameter("serverhttpskeystoredata");
if (serverHTTPSKeystoreValue != null)
parameters.setParameter(LiveLinkParameters.serverHTTPSKeystore,serverHTTPSKeystoreValue);
@@ -2267,7 +2251,7 @@ public class LivelinkConnector extends o
parameters.setParameter(LiveLinkParameters.ingestNtlmUsername,ingestNtlmUsername);
String ingestNtlmPassword = variableContext.getParameter("ingestntlmpassword");
if (ingestNtlmPassword != null)
- parameters.setObfuscatedParameter(LiveLinkParameters.ingestNtlmPassword,variableContext.mapKeyToPassword(ingestNtlmPassword));
+ parameters.setObfuscatedParameter(LiveLinkParameters.ingestNtlmPassword,ingestNtlmPassword);
String ingestKeystoreValue = variableContext.getParameter("ingestkeystoredata");
if (ingestKeystoreValue != null)
parameters.setParameter(LiveLinkParameters.ingestKeystore,ingestKeystoreValue);
@@ -4285,7 +4269,6 @@ public class LivelinkConnector extends o
String fileName = versInfo.getFileName();
Date creationDate = objInfo.getCreationDate();
Date modifyDate = versInfo.getModifyDate();
- Integer parentID = objInfo.getParentId();
RepositoryDocument rd = new RepositoryDocument();
@@ -4305,8 +4288,6 @@ public class LivelinkConnector extends o
rd.addField(GENERAL_CREATIONDATE_FIELD,creationDate.toString());
if (modifyDate != null)
rd.addField(GENERAL_MODIFYDATE_FIELD,modifyDate.toString());
- if (parentID != null)
- rd.addField(GENERAL_PARENTID,parentID.toString());
UserInformation owner = llc.getUserInformation(objInfo.getOwnerId().intValue());
UserInformation creator = llc.getUserInformation(objInfo.getCreatorId().intValue());
UserInformation modifier = llc.getUserInformation(versInfo.getOwnerId().intValue());
@@ -5634,7 +5615,7 @@ public class LivelinkConnector extends o
LLValue elem = getVersionValue();
if (elem == null)
return null;
- return new Long(elem.toLong("FILEDATASIZE"));
+ return new Long(elem.toInteger("FILEDATASIZE"));
}
/** Get file name.