[GitHub] [hbase] Apache9 commented on a change in pull request #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur…

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur…
URL: https://github.com/apache/hbase/pull/1221#discussion_r388784471
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java
 ##########
 @@ -547,6 +551,10 @@ public void insert(Procedure<?> proc, Procedure<?>[] subProcs) {
     }
     List<Mutation> mutations = new ArrayList<>(subProcs.length + 1);
     List<byte[]> rowsToLock = new ArrayList<>(subProcs.length + 1);
+    // Insert procedure may be called by master's rpc call. There are some check about the rpc call
+    // when mutate region. Here unset the current rpc call and set it back in finally block.
+    // See HBASE-23895 for more details.
+    Optional<RpcCall> rpcCall = RpcServer.unsetCurrentCall();
 
 Review comment:
   Pity we have to write the comment three times...
   
   Can be a follow on, to abstract a method for this logic...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services