You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by kevdoran <gi...@git.apache.org> on 2018/05/29 16:27:41 UTC
[GitHub] nifi-registry pull request #119: NIFIREG-172 Adds Swagger UI
GitHub user kevdoran opened a pull request:
https://github.com/apache/nifi-registry/pull/119
NIFIREG-172 Adds Swagger UI
Contains the following changes:
- Adds self-hosted Swagger UI to nifi-registry-web-api WAR at /swagger/ui.html
- Updates NOTICE for included ALv2 licensed source
- Adds Jersey filter exclusion for resources starting with /swagger/*
- Adds top-level authorizable resource type for /swagger/*
- Updates ResourceAuthorizationFilter configuration to include swagger resource type
- Corrects name of Position model object in Swagger specification
- Corrects duplicate operationId/nickname field for methods in FlowResource and BucketFlowResource
For reviewers:
- Verify /nifi-registry-api/swagger/ui.html is accessible and working in unsecured mode.
- Verify /nifi-registry-api/swagger/swagger.json returns a good Swagger spec.
- In secured mode, an initial admin should have access, as should any user who is granted read access to the "/swagger" resource
- Verify changes to NOTICE in source code and nifi-registry-assembly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevdoran/nifi-registry NIFIREG-172-swagger-ui
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-registry/pull/119.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #119
----
commit 8eef21c9481f795500a0a5d995deb2bdabf1899d
Author: Kevin Doran <kd...@...>
Date: 2018-05-29T16:13:06Z
NIFIREG-172 Adds Swagger UI
- Adds self-hosted Swagger UI to nifi-registry-web-api WAR at /swagger/ui.html
- Updates NOTICE for included ALv2 licensed source.
- Adds Jersey filter exclusion for resources starting with /swagger/*
- Adds top-level authorizable resource type for /swagger/*
- Updates ResourceAuthorizationFilter configuration to include swagger resource type
- Corrects name of Position model object in Swagger specification
- Corrects duplicate operationId/nickname field for methods in
FlowResource and BucketFlowResource
----
---
[GitHub] nifi-registry issue #119: NIFIREG-172 Adds Swagger UI
Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/119
Swagger part looks good, nice work!
I think nifi-registry-assembly/NOTICE just needs the 2017 changed to 2018 at the top.
---
[GitHub] nifi-registry issue #119: NIFIREG-172 Adds Swagger UI
Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/119
Thanks! looks good, will merge
---
[GitHub] nifi-registry issue #119: NIFIREG-172 Adds Swagger UI
Posted by kevdoran <gi...@git.apache.org>.
Github user kevdoran commented on the issue:
https://github.com/apache/nifi-registry/pull/119
@bbende I updated the copyright date range and also made a couple other updates to the README files while I was there. Let me know if you are good with these changes. Thanks!
---
[GitHub] nifi-registry issue #119: NIFIREG-172 Adds Swagger UI
Posted by kevdoran <gi...@git.apache.org>.
Github user kevdoran commented on the issue:
https://github.com/apache/nifi-registry/pull/119
Good eye, will update. And thanks for the review!
---
[GitHub] nifi-registry pull request #119: NIFIREG-172 Adds Swagger UI
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-registry/pull/119
---