You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/01 06:04:26 UTC
[GitHub] [arrow] vibhatha opened a new pull request, #13490: ARROW-16910: [C++] Add Equals method for FileFragment
vibhatha opened a new pull request, #13490:
URL: https://github.com/apache/arrow/pull/13490
Adding Equals method for `FileFragment`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
lidavidm merged PR #13490:
URL: https://github.com/apache/arrow/pull/13490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13490:
URL: https://github.com/apache/arrow/pull/13490#issuecomment-1171970659
https://issues.apache.org/jira/browse/ARROW-16910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on a diff in pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
vibhatha commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r915858606
##########
cpp/src/arrow/dataset/file_base.cc:
##########
@@ -89,6 +89,12 @@ Result<std::shared_ptr<io::InputStream>> FileSource::OpenCompressed(
return io::CompressedInputStream::Make(codec.get(), std::move(file));
}
+bool FileSource::Equals(const FileSource& other) const {
+ if (filesystem_ == NULLPTR) return false; // TODO: remove
Review Comment:
Yeah that make sense. Let's do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r916759669
##########
cpp/src/arrow/dataset/file_base.cc:
##########
@@ -89,6 +89,18 @@ Result<std::shared_ptr<io::InputStream>> FileSource::OpenCompressed(
return io::CompressedInputStream::Make(codec.get(), std::move(file));
}
+bool FileSource::Equals(const FileSource& other) const {
+ bool match_file_system = false;
+ if (filesystem_ == NULLPTR && other.filesystem_ == NULLPTR) {
+ match_file_system = true;
+ }
Review Comment:
don't do this, just
```cpp
bool match_file_system = (filesystem_ == nullptr && other.filesystem_ == nullptr) ||
(filesystem_ && other.filesystem_ && filesystem_->Equals(other.filesystem_);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on a diff in pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
vibhatha commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r912067303
##########
cpp/src/arrow/dataset/test_util.h:
##########
@@ -555,6 +555,21 @@ class FileFormatFixtureMixin : public ::testing::Test {
ASSERT_OK_AND_ASSIGN(predicate, predicate.Bind(*full_schema));
ASSERT_FINISHES_OK_AND_EQ(util::nullopt, fragment->CountRows(predicate, options));
}
+ void TestFragmentEquals() {
+ auto options = std::make_shared<ScanOptions>();
+ auto test_schema = schema({field("f64", float64())});
+ auto reader = this->GetRecordBatchReader(test_schema);
+ auto other_reader = this->GetRecordBatchReader(test_schema);
+ auto source = this->GetFileSource(reader.get());
+ auto other_source = this->GetFileSource(other_reader.get());
+
+ auto fragment = this->MakeFragment(*source);
+ auto other = this->MakeFragment(*other_source);
+
+ EXPECT_EQ(fragment->Equals(*other), false);
+ // TODO: Extend the test cases for Fragment
+ // when ARROW-16855 is merged.
Review Comment:
Yes. I need to mention this in other PR as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r912062334
##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -114,6 +114,9 @@ class ARROW_DS_EXPORT FileSource {
Result<std::shared_ptr<io::InputStream>> OpenCompressed(
util::optional<Compression::type> compression = util::nullopt) const;
+ /// \brief equality comparison with another FileSource
+ bool Equals(const FileSource& other) const;
Review Comment:
We may want to inherit from EqualityComparable https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/compare.h
##########
cpp/src/arrow/dataset/file_base.cc:
##########
@@ -89,6 +89,12 @@ Result<std::shared_ptr<io::InputStream>> FileSource::OpenCompressed(
return io::CompressedInputStream::Make(codec.get(), std::move(file));
}
+bool FileSource::Equals(const FileSource& other) const {
+ if (filesystem_ == NULLPTR) return false;
Review Comment:
This shouldn't be possible right?
Also `NULLPTR` is meant for headers, not source files
##########
cpp/src/arrow/dataset/test_util.h:
##########
@@ -555,6 +555,21 @@ class FileFormatFixtureMixin : public ::testing::Test {
ASSERT_OK_AND_ASSIGN(predicate, predicate.Bind(*full_schema));
ASSERT_FINISHES_OK_AND_EQ(util::nullopt, fragment->CountRows(predicate, options));
}
+ void TestFragmentEquals() {
+ auto options = std::make_shared<ScanOptions>();
+ auto test_schema = schema({field("f64", float64())});
+ auto reader = this->GetRecordBatchReader(test_schema);
+ auto other_reader = this->GetRecordBatchReader(test_schema);
+ auto source = this->GetFileSource(reader.get());
+ auto other_source = this->GetFileSource(other_reader.get());
+
+ auto fragment = this->MakeFragment(*source);
+ auto other = this->MakeFragment(*other_source);
+
+ EXPECT_EQ(fragment->Equals(*other), false);
+ // TODO: Extend the test cases for Fragment
+ // when ARROW-16855 is merged.
Review Comment:
Is that a TODO for the code here, or for the other PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on a diff in pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
vibhatha commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r912069046
##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -114,6 +114,9 @@ class ARROW_DS_EXPORT FileSource {
Result<std::shared_ptr<io::InputStream>> OpenCompressed(
util::optional<Compression::type> compression = util::nullopt) const;
+ /// \brief equality comparison with another FileSource
+ bool Equals(const FileSource& other) const;
Review Comment:
đź‘Ť
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on a diff in pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
vibhatha commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r913898245
##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -114,6 +114,9 @@ class ARROW_DS_EXPORT FileSource {
Result<std::shared_ptr<io::InputStream>> OpenCompressed(
util::optional<Compression::type> compression = util::nullopt) const;
+ /// \brief equality comparison with another FileSource
+ bool Equals(const FileSource& other) const;
Review Comment:
Ah I missed that. I will add this too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on a diff in pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
vibhatha commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r916825146
##########
cpp/src/arrow/dataset/file_base.cc:
##########
@@ -89,6 +89,14 @@ Result<std::shared_ptr<io::InputStream>> FileSource::OpenCompressed(
return io::CompressedInputStream::Make(codec.get(), std::move(file));
}
+bool FileSource::Equals(const FileSource& other) const {
+ bool match_file_system =
+ (filesystem_ == nullptr && other.filesystem_ == nullptr) ||
+ (filesystem_ && other.filesystem_ && filesystem_->Equals(other.filesystem_));
+ return file_info_.Equals(other.file_info_) && match_file_system &&
Review Comment:
ah yes good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on a diff in pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
vibhatha commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r912651490
##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -114,6 +114,9 @@ class ARROW_DS_EXPORT FileSource {
Result<std::shared_ptr<io::InputStream>> OpenCompressed(
util::optional<Compression::type> compression = util::nullopt) const;
+ /// \brief equality comparison with another FileSource
+ bool Equals(const FileSource& other) const;
Review Comment:
I added it, is it okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13490:
URL: https://github.com/apache/arrow/pull/13490#issuecomment-1171970704
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r915841157
##########
cpp/src/arrow/dataset/file_base.cc:
##########
@@ -89,6 +89,12 @@ Result<std::shared_ptr<io::InputStream>> FileSource::OpenCompressed(
return io::CompressedInputStream::Make(codec.get(), std::move(file));
}
+bool FileSource::Equals(const FileSource& other) const {
+ if (filesystem_ == NULLPTR) return false; // TODO: remove
Review Comment:
Actually, I'm sorry, I missed this constructor:
```cpp
explicit FileSource(std::shared_ptr<Buffer> buffer,
Compression::type compression = Compression::UNCOMPRESSED)
: buffer_(std::move(buffer)), compression_(compression) {}
```
But then the logic here should allow two files with null filesystems to compare equal, instead of always returning false.
##########
cpp/src/arrow/dataset/test_util.h:
##########
@@ -555,6 +555,19 @@ class FileFormatFixtureMixin : public ::testing::Test {
ASSERT_OK_AND_ASSIGN(predicate, predicate.Bind(*full_schema));
ASSERT_FINISHES_OK_AND_EQ(util::nullopt, fragment->CountRows(predicate, options));
}
+ void TestFragmentEquals() {
+ auto options = std::make_shared<ScanOptions>();
+ auto test_schema = schema({field("f64", float64())});
+ auto reader = this->GetRecordBatchReader(test_schema);
+ auto other_reader = this->GetRecordBatchReader(test_schema);
+ auto source = this->GetFileSource(reader.get());
+ auto other_source = this->GetFileSource(other_reader.get());
+
+ auto fragment = this->MakeFragment(*source);
+ auto other = this->MakeFragment(*other_source);
+
+ EXPECT_EQ(fragment->Equals(*other), false);
Review Comment:
Also check `fragment->Equals(*fragment)`?
Also use `EXPECT_TRUE` and `EXPECT_FALSE`
##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -46,7 +46,7 @@ namespace dataset {
/// \brief The path and filesystem where an actual file is located or a buffer which can
/// be read like a file
-class ARROW_DS_EXPORT FileSource {
+class ARROW_DS_EXPORT FileSource : public util::EqualityComparable<FileSource>{
Review Comment:
I think you'll need to run the formatter
##########
cpp/src/arrow/dataset/file_base.cc:
##########
@@ -89,6 +89,12 @@ Result<std::shared_ptr<io::InputStream>> FileSource::OpenCompressed(
return io::CompressedInputStream::Make(codec.get(), std::move(file));
}
+bool FileSource::Equals(const FileSource& other) const {
+ if (filesystem_ == NULLPTR) return false; // TODO: remove
Review Comment:
Please remove this then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
vibhatha commented on PR #13490:
URL: https://github.com/apache/arrow/pull/13490#issuecomment-1178788445
cc @westonpace @pitrou Not sure what is wrong here. Do you have an idea?
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/44112333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r916824436
##########
cpp/src/arrow/dataset/file_base.cc:
##########
@@ -89,6 +89,14 @@ Result<std::shared_ptr<io::InputStream>> FileSource::OpenCompressed(
return io::CompressedInputStream::Make(codec.get(), std::move(file));
}
+bool FileSource::Equals(const FileSource& other) const {
+ bool match_file_system =
+ (filesystem_ == nullptr && other.filesystem_ == nullptr) ||
+ (filesystem_ && other.filesystem_ && filesystem_->Equals(other.filesystem_));
+ return file_info_.Equals(other.file_info_) && match_file_system &&
Review Comment:
nit, but put `match_file_system` first to avoid unnecessarily evaluating `file_info_.Equals`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r912100719
##########
cpp/src/arrow/dataset/test_util.h:
##########
@@ -555,6 +555,21 @@ class FileFormatFixtureMixin : public ::testing::Test {
ASSERT_OK_AND_ASSIGN(predicate, predicate.Bind(*full_schema));
ASSERT_FINISHES_OK_AND_EQ(util::nullopt, fragment->CountRows(predicate, options));
}
+ void TestFragmentEquals() {
+ auto options = std::make_shared<ScanOptions>();
+ auto test_schema = schema({field("f64", float64())});
+ auto reader = this->GetRecordBatchReader(test_schema);
+ auto other_reader = this->GetRecordBatchReader(test_schema);
+ auto source = this->GetFileSource(reader.get());
+ auto other_source = this->GetFileSource(other_reader.get());
+
+ auto fragment = this->MakeFragment(*source);
+ auto other = this->MakeFragment(*other_source);
+
+ EXPECT_EQ(fragment->Equals(*other), false);
+ // TODO: Extend the test cases for Fragment
+ // when ARROW-16855 is merged.
Review Comment:
If it's for the other PR, please don't leave a comment here where it'll get forgotten
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13490:
URL: https://github.com/apache/arrow/pull/13490#issuecomment-1171970680
:warning: Ticket **has no components in JIRA**, make sure you assign one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r913801756
##########
cpp/src/arrow/dataset/file_base.cc:
##########
@@ -89,6 +89,12 @@ Result<std::shared_ptr<io::InputStream>> FileSource::OpenCompressed(
return io::CompressedInputStream::Make(codec.get(), std::move(file));
}
+bool FileSource::Equals(const FileSource& other) const {
+ if (filesystem_ == NULLPTR) return false;
Review Comment:
Can filesystem_ be null? I would have assumed not given this is a FileFragment (and it should be validated in the constructor)
##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -114,6 +114,9 @@ class ARROW_DS_EXPORT FileSource {
Result<std::shared_ptr<io::InputStream>> OpenCompressed(
util::optional<Compression::type> compression = util::nullopt) const;
+ /// \brief equality comparison with another FileSource
+ bool Equals(const FileSource& other) const;
Review Comment:
I don't see the change for FileSource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on a diff in pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
vibhatha commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r912290663
##########
cpp/src/arrow/dataset/test_util.h:
##########
@@ -555,6 +555,21 @@ class FileFormatFixtureMixin : public ::testing::Test {
ASSERT_OK_AND_ASSIGN(predicate, predicate.Bind(*full_schema));
ASSERT_FINISHES_OK_AND_EQ(util::nullopt, fragment->CountRows(predicate, options));
}
+ void TestFragmentEquals() {
+ auto options = std::make_shared<ScanOptions>();
+ auto test_schema = schema({field("f64", float64())});
+ auto reader = this->GetRecordBatchReader(test_schema);
+ auto other_reader = this->GetRecordBatchReader(test_schema);
+ auto source = this->GetFileSource(reader.get());
+ auto other_source = this->GetFileSource(other_reader.get());
+
+ auto fragment = this->MakeFragment(*source);
+ auto other = this->MakeFragment(*other_source);
+
+ EXPECT_EQ(fragment->Equals(*other), false);
+ // TODO: Extend the test cases for Fragment
+ // when ARROW-16855 is merged.
Review Comment:
Sure. I will move it to the other PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on a diff in pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment
Posted by GitBox <gi...@apache.org>.
vibhatha commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r912291015
##########
cpp/src/arrow/dataset/file_base.cc:
##########
@@ -89,6 +89,12 @@ Result<std::shared_ptr<io::InputStream>> FileSource::OpenCompressed(
return io::CompressedInputStream::Make(codec.get(), std::move(file));
}
+bool FileSource::Equals(const FileSource& other) const {
+ if (filesystem_ == NULLPTR) return false;
Review Comment:
Mmm sorry didn’t catch this one clearly. Could you explain a bit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org