You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by borisroman <gi...@git.apache.org> on 2015/11/08 19:57:47 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1046
CLOUDSTACK-9044: Add RBD Primary Storage to the Zone Wizard.
Added to option to use RBD as primary storage in the Zone Wizard.
Pure UI change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-9044
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1046.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1046
----
commit c4f64dce2127c8cef4e28aec5017c5f654c9e584
Author: Boris Schrijver <bo...@pcextreme.nl>
Date: 2015-11-08T17:22:39Z
CLOUDSTACK-9044: Add RBD Primary Storage to the Zone Wizard.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...
Posted by kevindierkx <gi...@git.apache.org>.
Github user kevindierkx commented on the pull request:
https://github.com/apache/cloudstack/pull/1046#issuecomment-155012289
The code looks fine to me.
@DaanHoogland @borisroman I agree decoupling the UI from the main Cloudstack project would be the better choice. Development on the main Cloudstack project wouldn't be halted by the frontend and the end user would have more choice in what frontend they would use. It would also be a great moment to look at all the frontend code and make a list of all the things that should be changed or improved. (Like testing...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1046#issuecomment-155153126
I saw this in action today. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1046#issuecomment-155004057
@davidamorimfaria If we need to reinstoll a devcloud this week, can we verify as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1046
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1046#issuecomment-154862003
@DaanHoogland I share the same opinion. I would actually like to see the UI be a separate project. But in my opinion that supersedes this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...
Posted by kevindierkx <gi...@git.apache.org>.
Github user kevindierkx commented on the pull request:
https://github.com/apache/cloudstack/pull/1046#issuecomment-155020178
@davidamorimfaria @borisroman Took the commit for a spin, looks like it does what it suppose to do. (Adding form elements when certain conditions are met.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1046#issuecomment-155218538
I added a RBD pool using the ZoneWizard:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1046#issuecomment-155001934
@DaanHoogland @borisroman Fully agree, the UI is currently not the best, but this change can go in.
I want to LGTM, but it's hard to test. The code seems fine to me. I'll give my LGTM after @borisroman shows me it works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...
Posted by davidamorimfaria <gi...@git.apache.org>.
Github user davidamorimfaria commented on the pull request:
https://github.com/apache/cloudstack/pull/1046#issuecomment-155010677
I will have a chance to test it this week
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1046#issuecomment-155378548
Ping @remibergsma @borisroman
This PR LGTM :+1:
I reviewed the code and read the comments in the PR, also looking at the tests @borisroman did and the screenshots he shared.
@remibergsma, you can proceed with the merge.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1046#issuecomment-154860964
though this is a needed change, would we want to solve it more generally so there will be only point of maintenance?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---