Re: [PR] Set snapCPG in online copy request to fix snapshot failures on cloned volumes [cloudstack]

["Copilot (via GitHub)" <gi...@apache.org>]

Copilot commented on code in PR #12955:
URL: https://github.com/apache/cloudstack/pull/12955#discussion_r3050586836


##########
plugins/storage/volume/primera/src/main/java/org/apache/cloudstack/storage/datastore/adapter/primera/PrimeraAdapter.java:
##########
@@ -384,6 +384,7 @@ public ProviderVolume copy(ProviderAdapterContext context, ProviderAdapterDataOb
             // Online copy configuration: immediate clone with deduplication and compression
             parms.setOnline(true);
             parms.setDestCPG(cpg);
+            parms.setSnapCPG(snapCpg);
             parms.setTpvv(false);
             parms.setReduce(true);
             logger.debug("PrimeraAdapter: Configuring online copy - destination CPG: '{}', deduplication enabled, thin provisioning disabled", cpg);

Review Comment:
   The debug log message is now misleading/incomplete because the code configures `snapCPG` (and also `reduce`) but the log only prints `destCPG` and omits `snapCPG`. This makes troubleshooting harder and can contradict operator expectations (the PR description/test output includes `snapCPG`). Update the log format and arguments to include `snapCpg` (and optionally `reduce`) so the message reflects the actual online copy configuration.
   ```suggestion
               logger.debug("PrimeraAdapter: Configuring online copy - destination CPG: '{}', snapshot CPG: '{}', reduce enabled: {}, thin provisioning enabled: {}",
                       cpg, snapCpg, true, false);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org