You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2025/07/10 11:57:09 UTC

[Impala-ASF-CR] IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

k.venureddy2103@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23152

Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
......................................................................

IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

HIVE-28976 modified CommitTxnMessage to pass write ids in the message.
But, catalogd do not expect write ids in the CommitTxnMessage.
writeEventInfos is explicitly fetched from HMS using
getAllWriteEventInfo() API and populate them to its local
CommitTxnMessage object using CommitTxnMessage.addWriteEventInfo().
Since the write ids are already present in CommitTxnMessage, when we
do addWriteEventInfo() on it, write ids are added again to the
writeIds list in CommitTxnMessage and cause the
IndexOutOfBoundsException upon CommitTxnMessage.getTableObj(i).

Fix is to not populate the fetched WriteEventInfos to local
CommitTxnMessage object. Instead, use them directly.

Testing:
- Executed existing tests.

Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
---
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
1 file changed, 47 insertions(+), 37 deletions(-)

git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/23152/1
--
To view, visit http://gerrit.cloudera.org:8080/23152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <k....@gmail.com>

[Impala-ASF-CR] IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23152 )

Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12159/


-- 
To view, visit http://gerrit.cloudera.org:8080/23152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Sat, 12 Jul 2025 05:42:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23152 )

Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Jul 2025 04:03:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23152 )

Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12146/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/23152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 10 Jul 2025 19:58:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.

Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23152 )

Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23152/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java:

http://gerrit.cloudera.org:8080/#/c/23152/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@960
PS1, Line 960: Map<TableName, List<Pair<Integer, Table>>>
The Table is only used from the first element of the list - I think that it would be clear to use Pair<Table, List<Integer>> instead of List<Pair<Integer, Table>>



-- 
To view, visit http://gerrit.cloudera.org:8080/23152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 10 Jul 2025 14:08:56 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23152 )

Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 10 Jul 2025 18:15:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23152 )

Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19812/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 10 Jul 2025 19:47:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23152 )

Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19795/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 10 Jul 2025 12:22:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.

k.venureddy2103@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/23152 )

Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23152/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java:

http://gerrit.cloudera.org:8080/#/c/23152/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@960
PS1, Line 960: Map<TableName, Pair<Table, List<Integer>>>
> The Table is only used from the first element of the list - I think that it
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/23152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Jul 2025 04:04:42 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23152 )

Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12162/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/23152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Sat, 12 Jul 2025 06:02:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23152 )

Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
......................................................................

IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

HIVE-28976 modified CommitTxnMessage to pass write ids in the message.
But, catalogd do not expect write ids in the CommitTxnMessage.
writeEventInfos is explicitly fetched from HMS using
getAllWriteEventInfo() API and populate them to its local
CommitTxnMessage object using CommitTxnMessage.addWriteEventInfo().
Since the write ids are already present in CommitTxnMessage, when we
do addWriteEventInfo() on it, write ids are added again to the
writeIds list in CommitTxnMessage and cause the
IndexOutOfBoundsException upon CommitTxnMessage.getTableObj(i).

Fix is to not populate the fetched WriteEventInfos to local
CommitTxnMessage object. Instead, use them directly.

Testing:
- Executed existing tests.

Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Reviewed-on: http://gerrit.cloudera.org:8080/23152
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
1 file changed, 50 insertions(+), 39 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23152 )

Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12136/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/23152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jul 2025 11:59:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23152 )

Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Sat, 12 Jul 2025 06:02:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23152 )

Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Sat, 12 Jul 2025 12:00:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23152 )

Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Jul 2025 23:24:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Csaba Ringhofer, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/23152

to look at the new patch set (#2).

Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
......................................................................

IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

Fix is to not populate the fetched WriteEventInfos to local
CommitTxnMessage object. Instead, use them directly.

Testing:
- Executed existing tests.

Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
---
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
1 file changed, 50 insertions(+), 39 deletions(-)

git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/23152/2
--
To view, visit http://gerrit.cloudera.org:8080/23152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23152 )

Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
......................................................................


Patch Set 2: Code-Review+2

LGTM. Carry Csaba's +1.


-- 
To view, visit http://gerrit.cloudera.org:8080/23152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Jul 2025 23:24:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23152 )

Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12159/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/23152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Gerrit-Change-Number: 23152
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Jul 2025 23:24:49 +0000
Gerrit-HasComments: No