You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/15 20:50:58 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #2881: Add Decimal Arithmetic
tustvold opened a new pull request, #2881:
URL: https://github.com/apache/arrow-rs/pull/2881
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Follow on to https://github.com/apache/arrow-rs/pull/2770
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Adds support to the numeric kernels for decimal arrays. It is worth noting that these ignore precision and scale, it is up to the user to ensure the arrays have valid data types. Dyn kernels will follow in a subsequent PR.
# Are there any user-facing changes?
No
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
FYI @kmitchene
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #2881: Add Decimal Arithmetic
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #2881:
URL: https://github.com/apache/arrow-rs/pull/2881#issuecomment-1279833824
Oh, some traits need to be implemented for `i256`:
```
--> arrow/src/datatypes/numeric.rs:471:17
|
471 | type Simd = i256;
| ^^^^ no implementation for `arrow_buffer::i256 + arrow_buffer::i256`
|
= help: the trait `Add` is not implemented for `arrow_buffer::i256`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #2881: Add Decimal Arithmetic
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2881:
URL: https://github.com/apache/arrow-rs/pull/2881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liukun4515 commented on pull request #2881: Add Decimal Arithmetic
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on PR #2881:
URL: https://github.com/apache/arrow-rs/pull/2881#issuecomment-1282090941
after this merged, we can replace this op in the datafusion for decimal data type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2881: Add Decimal Arithmetic
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2881:
URL: https://github.com/apache/arrow-rs/pull/2881#issuecomment-1295725913
Benchmark runs are scheduled for baseline = 87c9db437a530e246528e72d4af902b78ce2623e and contender = e6eb8341cb20460847ba12949ad7a937a62d76b7. e6eb8341cb20460847ba12949ad7a937a62d76b7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7b9482c9aa9b42cc9bbb5b95ce3eccf5...8409f7b977a54d179fa31300194c7d71/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d2c0716935c14cc39a495a1e806cf9e0...c3fb410b9d3945bcabb5c4fcbb5fc2bc/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/655796fb218e412983f33cac851ca1ee...052e087596474d69a95f13fe8620e4e3/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1f0b5856bf1a49b98dbff3a9783fd907...95421cc0236a48e1b1c1f01a3dc9a324/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org