[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #11679: JDBC-core module delete getDefaultMetaData()

[GitBox <gi...@apache.org>]

menghaoranss commented on a change in pull request #11679:
URL: https://github.com/apache/shardingsphere/pull/11679#discussion_r684020784



##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/executor/DriverJDBCExecutor.java
##########
@@ -48,10 +48,13 @@
     
     private final JDBCLockEngine jdbcLockEngine;
     
-    public DriverJDBCExecutor(final MetaDataContexts metaDataContexts, final JDBCExecutor jdbcExecutor) {
+    private final String schemaName;
+    
+    public DriverJDBCExecutor(final MetaDataContexts metaDataContexts, final JDBCExecutor jdbcExecutor, final String schemaName) {

Review comment:
       I don't think it's a good idea to pass `schemaName` in Executor




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org