[GitHub] [ignite-3] lowka commented on a diff in pull request #2100: [IGNITE-19496] Sql. Implement SqlSchemaManager on top of CatalogService.

["lowka (via GitHub)" <gi...@apache.org>]

lowka commented on code in PR #2100:
URL: https://github.com/apache/ignite-3/pull/2100#discussion_r1214207341


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java:
##########
@@ -254,6 +255,8 @@ private CompletableFuture<QueryPlan> prepareDml(SqlNode sqlNode, PlanningContext
             // Convert to Relational operators graph
             IgniteRel igniteRel = optimize(validatedNode, planner);
 
+            System.err.println(RelOptUtil.dumpPlan("DUMP", igniteRel, SqlExplainFormat.TEXT, SqlExplainLevel.NON_COST_ATTRIBUTES));

Review Comment:
   Sure.



##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/IgniteIndex.java:
##########
@@ -82,12 +84,22 @@ public enum Type {
      */
     public IgniteIndex(Index<?> index) {
         this.index = Objects.requireNonNull(index, "index");

Review Comment:
   I think I should revert these changes as they are not necessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org