[GitHub] [calcite] danny0405 commented on a change in pull request #1592: [CALCITE-3512] Query fails when comparing Time/TimeStamp types

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #1592: [CALCITE-3512] Query fails when comparing Time/TimeStamp types
URL: https://github.com/apache/calcite/pull/1592#discussion_r348860541
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java
 ##########
 @@ -788,22 +788,23 @@ private static boolean isNumeric(Class type) {
 
   /** Test case for
    * <a href="https://issues.apache.org/jira/browse/CALCITE-1569">[CALCITE-1569]
-   * Date condition can generates Integer == Integer, which is always
-   * false</a>. */
+   * Date condition can generates Integer == Integer, which is always false</a> and
+   * <a href="https://issues.apache.org/jira/browse/CALCITE-3512">[CALCITE-3512]
+   * Query fails when comparing Time/TimeStamp types</a>. */
   @Test public void testDateCanCompare() {
-    final String sql = "select a.v\n"
-        + "from (select \"sqlDate\" v\n"
+    final String sql = "select a.v1, a.v2, a.v3\n"
 
 Review comment:
   Oops, this test is messed up, i think we better split it into 3 tests: `testDateCanCompare` `testTimeCanCompare` and `testTimestampCanCompare`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services