You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/20 09:36:17 UTC
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
github-actions[bot] commented on code in PR #16123:
URL: https://github.com/apache/doris/pull/16123#discussion_r1082287281
##########
be/src/service/brpc_http_service.h:
##########
@@ -0,0 +1,117 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include <brpc/http_status_code.h>
+#include <brpc/restful.h>
+#include <brpc/server.h>
+
+#include <string>
+
+#include "gen_cpp/http_service.pb.h"
+#include "runtime/exec_env.h"
+#include "util/easy_json.h"
+
+namespace brpc {
+class Controller;
+}
+
+namespace doris {
+class BrpcHttpHelper;
+
+class BrpcHttpService :public PHttpService {
+ BrpcHttpService(ExecEnv* exec_env);
+
+ void check_rpc_channel(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void reset_rpc_channel(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+
+ void config(::google::protobuf::RpcController* controller, const ::doris::HttpRequest* request,
+ ::doris::HttpResponse* response, ::google::protobuf::Closure* done) override;
+ void health(::google::protobuf::RpcController* controller, const ::doris::HttpRequest* request,
+ ::doris::HttpResponse* response, ::google::protobuf::Closure* done) override;
+ void jeprofile(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void meta(::google::protobuf::RpcController* controller, const ::doris::HttpRequest* request,
+ ::doris::HttpResponse* response, ::google::protobuf::Closure* done) override;
+ void metrics(::google::protobuf::RpcController* controller, const ::doris::HttpRequest* request,
+ ::doris::HttpResponse* response, ::google::protobuf::Closure* done) override;
+ void monitor(::google::protobuf::RpcController* controller, const ::doris::HttpRequest* request,
+ ::doris::HttpResponse* response, ::google::protobuf::Closure* done) override;
+ void pad_rowset(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void pprof(::google::protobuf::RpcController* controller, const ::doris::HttpRequest* request,
+ ::doris::HttpResponse* response, ::google::protobuf::Closure* done) override;
+ void snapshot(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void version(::google::protobuf::RpcController* controller, const ::doris::HttpRequest* request,
+ ::doris::HttpResponse* response, ::google::protobuf::Closure* done) override;
+
+ void check_tablet_segement(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void check_sum(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void compaction(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void reload_tablet(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void restore_tablet(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void tablet_migration(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void distribution(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void tablet_info(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+
+ void download(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void stream_load(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void stream_load_2pc(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+
+private:
+ ExecEnv* _exec_env;
Review Comment:
warning: private field '_exec_env' is not used [clang-diagnostic-unused-private-field]
```cpp
ExecEnv* _exec_env;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org