You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/14 08:39:09 UTC
[GitHub] [pulsar] lhotari opened a new issue, #16054: Broker cache eviction evicts entries that haven't been read by active consumers
lhotari opened a new issue, #16054:
URL: https://github.com/apache/pulsar/issues/16054
**Describe the bug**
#12045 changed cache eviction. The problem is that cache eviction is done to the position whatever happens to be the first cursor in the "heap" list in ManagedCursorContainer. There's a chance for a race condition: another cursor in the list might have an older position, but that hasn't been updated in the ordered data structure ("heap") when the method is called. The cache eviction will take the read position directly from the first cursor and it ignores and older positions.
When the consumer for the other cursor does a read, the entries are no more in the cache and there will be a cache miss.
**To Reproduce**
It should be possible to reproduce this in a multi-consumer scenario where the speed of the consumers varies.
**Expected behavior**
Cache eviction should properly consider all active consumers. This was the state before #12045 and #14985 changes.
**Additional context**
#12045, #14985, #16049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on issue #16054: Broker cache eviction evicts entries that haven't been read by active consumers
Posted by GitBox <gi...@apache.org>.
lhotari commented on issue #16054:
URL: https://github.com/apache/pulsar/issues/16054#issuecomment-1154898378
@315157973 @lordcheng10 @merlimat @codelipenghui What's your thoughts on this issue?
I wonder if the need for #14985 was caused by the regression described in this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on issue #16054: Broker cache eviction evicts entries that haven't been read by active consumers
Posted by GitBox <gi...@apache.org>.
lhotari commented on issue #16054:
URL: https://github.com/apache/pulsar/issues/16054#issuecomment-1181849489
@315157973 @lordcheng10 @merlimat @codelipenghui please take a look at this issue since it seems that the broker cache is broken atm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on issue #16054: Broker cache eviction evicts entries that haven't been read by active consumers
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on issue #16054:
URL: https://github.com/apache/pulsar/issues/16054#issuecomment-1196191112
> I wonder if the need for #14985 was caused by the regression described in this issue?
In #14985, miss cache is caused by data re-pushing due to restart of some consumer clients @lhotari
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on issue #16054: Broker cache eviction evicts entries that haven't been read by active consumers
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #16054:
URL: https://github.com/apache/pulsar/issues/16054#issuecomment-1181854618
this is partially related
https://github.com/apache/pulsar/issues/16421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on issue #16054: Broker cache eviction evicts entries that haven't been read by active consumers
Posted by GitBox <gi...@apache.org>.
lhotari commented on issue #16054:
URL: https://github.com/apache/pulsar/issues/16054#issuecomment-1154928287
@315157973 @lordcheng10 I'll work on a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari closed issue #16054: Broker cache eviction evicts entries that haven't been read by active consumers
Posted by GitBox <gi...@apache.org>.
lhotari closed issue #16054: Broker cache eviction evicts entries that haven't been read by active consumers
URL: https://github.com/apache/pulsar/issues/16054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org