[GitHub] [rocketmq] miles-ton commented on a diff in pull request #6364: [ISSUE #6357]shouldn't use computePullFromWhere()

["miles-ton (via GitHub)" <gi...@apache.org>]

miles-ton commented on code in PR #6364:
URL: https://github.com/apache/rocketmq/pull/6364#discussion_r1146406414


##########
client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java:
##########
@@ -521,7 +521,13 @@ private boolean updateProcessQueueTableInRebalance(final String topic, final Set
                 this.removeDirtyOffset(mq);
                 ProcessQueue pq = createProcessQueue(topic);
                 pq.setLocked(true);
-                long nextOffset = this.computePullFromWhere(mq);
+                long nextOffset;
+                try {
+                    nextOffset = this.computePullFromWhereWithException(mq);
+                } catch (MQClientException e) {
+                    log.info("doRebalance, {}, compute offset failed, {}", consumerGroup, mq);

Review Comment:
   thanks for your comment. sure, it should be log.warn(), i will change it later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org