You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cayenne.apache.org by Andrus Adamchik <an...@objectstyle.org> on 2016/09/29 06:44:11 UTC

Ordering chaining PR

https://github.com/apache/cayenne/pull/112

(For those who don't follow commits@ or GitHub)

I am personally +0 on this patch. I commented in more detail on the PR itself.

Thoughts?

Andrus

Re: Ordering chaining PR

Posted by Andrus Adamchik <an...@objectstyle.org>.

Even Property.ascs()/descs() and friends are probably redundant for in-memory sorting purposes.

Andrus


> On Sep 29, 2016, at 10:01 AM, Andrus Adamchik <an...@objectstyle.org> wrote:
> 
> Another consideration - Ordering implements Comparator<Object>. In Java 8 Comparator has chaining methods. So Orderings class may be redundant.
> 
> Andrus
> 
>> On Sep 29, 2016, at 9:44 AM, Andrus Adamchik <an...@objectstyle.org> wrote:
>> 
>> https://github.com/apache/cayenne/pull/112
>> 
>> (For those who don't follow commits@ or GitHub)
>> 
>> I am personally +0 on this patch. I commented in more detail on the PR itself.
>> 
>> Thoughts?
>> 
>> Andrus
>

Re: Ordering chaining PR

Posted by Andrus Adamchik <an...@objectstyle.org>.

Another consideration - Ordering implements Comparator<Object>. In Java 8 Comparator has chaining methods. So Orderings class may be redundant.

Andrus

> On Sep 29, 2016, at 9:44 AM, Andrus Adamchik <an...@objectstyle.org> wrote:
> 
> https://github.com/apache/cayenne/pull/112
> 
> (For those who don't follow commits@ or GitHub)
> 
> I am personally +0 on this patch. I commented in more detail on the PR itself.
> 
> Thoughts?
> 
> Andrus