You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@madlib.apache.org by iyerr3 <gi...@git.apache.org> on 2018/07/04 00:38:45 UTC

[GitHub] madlib pull request #288: Jira:1239: Converts features from multiple columns...

Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/288#discussion_r199981733
  
    --- Diff: src/config/Modules.yml ---
    @@ -50,3 +50,4 @@ modules:
         - name: validation
           depends: ['array_ops', 'regress']
         - name: stemmer
    +    - name: cols_vec
    --- End diff --
    
    I'm not convinced that we need a new module for this functionality. IMO this is better suited for the `utilities` module as a separate file.  


---