[jira] [Commented] (AMBARI-10456) Ambari Server Deadlock When Mapping Hosts

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493485#comment-14493485 ] 

Hadoop QA commented on AMBARI-10456:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12725132/AMBARI-10456.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 7 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The test build failed in ambari-server 

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/2325//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/2325//console

This message is automatically generated.

> Ambari Server Deadlock When Mapping Hosts
> -----------------------------------------
>
>                 Key: AMBARI-10456
>                 URL: https://issues.apache.org/jira/browse/AMBARI-10456
>             Project: Ambari
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Jonathan Hurley
>            Assignee: Jonathan Hurley
>            Priority: Critical
>             Fix For: 2.1.0
>
>         Attachments: AMBARI-10456.patch, dump.txt
>
>
> When mapping hosts concurrently with reading information from a cluster, there was a deadlock between the building the cluster health report and mapping the new hosts. 
> A few changes to note here:
> - ClustersImpl uses concurrent maps; there's really no need to keep the internal lock. I removed it in several places where the cluster is guaranteed to be available (such as when using the ID to retrieve the cluster). The concurrent maps guard against concurrent modifications.
> - The Ambari Event Publisher was actually synchronous. This not only caused bottlenecks, but also contributed to a secondary deadlock detected while fixing the original issue. It was changed into a single-threaded asynchronous bus. Consumers of this bus should never rely on it to perform its actions in order to perform their own logic, so changing the behavior seemed correct



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)