[GitHub] [lucene-solr] murblanc commented on a change in pull request #1845: SOLR-14613: Autoscaling replacement using placement plugins

[GitBox <gi...@apache.org>]

murblanc commented on a change in pull request #1845:
URL: https://github.com/apache/lucene-solr/pull/1845#discussion_r488557460



##########
File path: solr/solrj/src/resources/apispec/cluster.Commands.json
##########
@@ -141,6 +141,21 @@
           }
         }
       }
-    }
+    },
+    "set-placement-plugin": {

Review comment:
       Can you please point me @noblepaul or @sigram to existing code in which some of the commands on a path (here `/api/cluster`) use annotations and some use apispec?
   I haven't found such a mix, and given existing `/api/cluster` commands (`add-role`, `remove-role`, `set-property`, `set-obj-property`) are defined in the apispec json file, that's where I've added the two new ones.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org