[GitHub] [hadoop] swamirishi edited a comment on pull request #2133: HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy

[GitBox <gi...@apache.org>]

swamirishi edited a comment on pull request #2133:
URL: https://github.com/apache/hadoop/pull/2133#issuecomment-671476116


   > @swamirishi while you are looking at distcp, have a look at #1111 and see what you think about it...its test code is pretty close to yours, the functionality orthoganal
   
   @steveloughran The testcase in the aforementioned PR is not testing for Atomic copy. It would not matter for this particular code flow as the missing deletion from target FileSystem would be always happening over the CONF_LABEL_TARGET_WORK_PATH & not over the CONF_LABEL_TARGET_FINAL_PATH. So in this code flow one need not test for Atomic Copy case where Work Path & Final Path would be different


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org