You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/25 12:21:11 UTC

[GitHub] [airflow] ephraimbuddy commented on pull request #21901: Add `max_active_runs_reached` column to DagModel

ephraimbuddy commented on PR #21901:
URL: https://github.com/apache/airflow/pull/21901#issuecomment-1108500245

   > @ephraimbuddy - planning to continue on this (I guess after 2.3.0 :) ?
   
   Yes. After 2.3.0.
   
   > On a second tought I might be completely wrong and this PR works.
   
   > dag_model.calculate_dagrun_date_fields is called only in one place and DagModel is locked there - this is very good.
   In the self._max_active_runs_reached we are still changing the max_active_runs_reached field at three places (with different locks) - this part feels bit iffy.
   
   I hate that we are recalculating some fields... I will continue on this PR after 2.3.0. 
   Maybe find a better way other than what I have here
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org