[GitHub] [cassandra-sidecar] tolbertam opened a new pull request #5: Read config from sidecar.config System Property instead of classpath

[GitBox <gi...@apache.org>]

tolbertam opened a new pull request #5: Read config from sidecar.config System Property instead of classpath
URL: https://github.com/apache/cassandra-sidecar/pull/5
 
 
   Howdy all!  I was experimenting earlier today with running multiple sidecar instances against multiple local C* nodes (using a ccm cluster) and noticed that the distribution of sidecar did not include the conf directory and instead was loading sidecar.yaml from the classpath.  I noticed the lines in build.gradle:
   
   ```
   // Config file location should be in file:/// format for local files,
   // when we have the fix for adding /conf directory to classpaht, we can get away with below default JvmArg
   ```
   
   From this statement I assume the expectation was that eventually the `sidecar.config` system property would be used to locate the sidecar.yaml file, so I went ahead and changed things to work this way among other things documented in the initial commit message below:
   
   ---
   
   Alters configuration processing to read from `sidecar.config` system
   property instead of using `Configurations` file resolution, which seems
   to read from classpath first.
   
   Also does the following:
   
   * Move `conf` into `src/dist/config`.  This causes the `conf` directory
     to be included in the tar and zip distributions where it previously
     was not.
   * Don't add `conf` directory to classpath.  For logging add
     `-Dlogback.configuration` to arguments.  Also add `logback-test.xml`
     to have different logging behavior for tests.
   * Copy agents into `build/install/appName/agents` directly instead of
     `src/dist`. Make `copyDist` depend on `copyJolokia`. This also has
     the side effect of having agents copied to the project directory, so
     `bin/CassandraSidecarDaemon` works after `./gradlew build`.
   * Improve logging to include full address instead of just port.
   * Add generated paths to gitignore

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org