[GitHub] [incubator-brpc] yanglimingcn edited a comment on issue #722: Mysql transaction

[GitBox <gi...@apache.org>]

yanglimingcn edited a comment on issue #722: Mysql transaction
URL: https://github.com/apache/incubator-brpc/pull/722#issuecomment-482073540
 
 
   https://github.com/yanglimingcn/brpc/commit/56e76f49e6f73d3eb1785b3494f317bb1d3900d5
   @jamesge 麻烦帮我评审一下，这次提交，把pipeline的方式换成correlation_id，是不是更合理些？
   这里是通过判断_auth_context是否为NULL，来判断是否需要做权限校验的，做完权限校验，再把_auth_context置为NULL，这时候就会报错：
   Impossible! This function is supposed to be called only once when verification succeeds in server side only once when verification succeeds in server side
    这里需要把void Controller::set_auth_context(const AuthContext* ctx) 这个函数改一下，把里面的_auth_context != NULL注释掉。
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org