Re: [PR] ARTEMIS-4909 use names that match original xml tags [activemq-artemis]

["gemmellr (via GitHub)" <gi...@apache.org>]

gemmellr commented on code in PR #5075:
URL: https://github.com/apache/activemq-artemis/pull/5075#discussion_r1705702940


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java:
##########
@@ -4689,11 +4689,11 @@ private static void setUnsetQueueParamsToDefaults(QueueConfiguration c) {
 
    private void deployReloadableConfigFromConfiguration() throws Exception {
       if (configurationReloadDeployed.compareAndSet(false, true)) {
-         ActiveMQServerLogger.LOGGER.reloadingConfiguration("security");
+         ActiveMQServerLogger.LOGGER.reloadingConfiguration("security-settings");

Review Comment:
   I could see making this "security settings", i.e adding " settings" to make it consistent with the "address settings" one below (which would remain as it was), but I dont think they should strictly match the XML tags since that may in fact not be where the configuration is coming from.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact