[jira] [Commented] (HUDI-2359) Add tests for _hoodie_is_deleted functionality

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HUDI-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404757#comment-17404757 ] 

ASF GitHub Bot commented on HUDI-2359:
--------------------------------------

rahil-c opened a new pull request #3538:
URL: https://github.com/apache/hudi/pull/3538


   ## What is the purpose of the pull request
   
   JIRA : https://issues.apache.org/jira/browse/HUDI-2359
   
   In issue thread https://github.com/apache/hudi/issues/3321, there was a discussion around the functionality of `hoodie_is_deleted` field.
   
   1. We wanted to ensure that when this field was being set to `true`, that the specified record would be deleted.
   2. We also wanted to make sure that this field only needed to be set to `true` for an incoming record, and not for existing records.
   
   The goal of this PR is to add unit tests that follow similar reproductions as discussed in the above github issue thread.
   
   @nsivabalan example https://gist.github.com/nsivabalan/e5ac69677ed05e9f2749fae67d3abc19 
   @nmukerje example https://github.com/nmukerje/misc/blob/master/Hudi/Hudi_Pyspark_Delete_Upsert_Test.ipynb
   
   ## Verify this pull request
   
   
   This change added test methods to existing test classes and can be verified as follows:
   ```
   mvn -Dtest=TestMORDataSource#testHoodieIsDeletedMOR test -DfailIfNoTests=false -pl hudi-spark-datasource/hudi-spark/
   
   mvn -Dtest=TestCOWDataSource#testHoodieIsDeletedCOW test -DfailIfNoTests=false -pl hudi-spark-datasource/hudi-spark/
   ```
   
   ## Committer checklist
   
    - [] Has a corresponding JIRA in PR title & commit
    
    - [] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add tests for _hoodie_is_deleted functionality
> ----------------------------------------------
>
>                 Key: HUDI-2359
>                 URL: https://issues.apache.org/jira/browse/HUDI-2359
>             Project: Apache Hudi
>          Issue Type: Test
>            Reporter: Sagar Sumit
>            Priority: Minor
>
> https://github.com/apache/hudi/issues/3321



--
This message was sent by Atlassian Jira
(v8.3.4#803005)