You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2014/01/30 10:02:28 UTC
git commit: ISIS-629: don't trample other parameters when changing
drop-down
Updated Branches:
refs/heads/master b99640031 -> 2645b09a1
ISIS-629: don't trample other parameters when changing drop-down
Project: http://git-wip-us.apache.org/repos/asf/isis/repo
Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/2645b09a
Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/2645b09a
Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/2645b09a
Branch: refs/heads/master
Commit: 2645b09a1d2058833dbef53d0955b8aec6bfc20d
Parents: b996400
Author: Dan Haywood <da...@haywood-associates.co.uk>
Authored: Thu Jan 30 09:00:24 2014 +0000
Committer: Dan Haywood <da...@haywood-associates.co.uk>
Committed: Thu Jan 30 09:00:24 2014 +0000
----------------------------------------------------------------------
.../ui/components/actions/ActionParametersFormPanel.java | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/isis/blob/2645b09a/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actions/ActionParametersFormPanel.java
----------------------------------------------------------------------
diff --git a/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actions/ActionParametersFormPanel.java b/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actions/ActionParametersFormPanel.java
index 8542120..93990fc 100644
--- a/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actions/ActionParametersFormPanel.java
+++ b/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actions/ActionParametersFormPanel.java
@@ -252,7 +252,12 @@ public class ActionParametersFormPanel extends PanelAbstract<ActionModel> {
getAuthenticationSession().getMessageBroker().addWarning(ex.getMessage());
return;
}
- target.add(this);
+
+ // previously this method was also doing:
+ // target.add(this);
+ // ie to update the entire form (in addition to the updates to the individual impacted parameter fields
+ // done in the loop above). However, that logic is wrong, because any values entered in the browser
+ // get trampled over (ISIS-629).
}
@Override