[GitHub] [incubator-superset] donbowman commented on a change in pull request #6795: Add HTTP Basic Auth for Druid (Issue #4776)

[GitBox <gi...@apache.org>]

donbowman commented on a change in pull request #6795: Add HTTP Basic Auth for Druid (Issue #4776)
URL: https://github.com/apache/incubator-superset/pull/6795#discussion_r264662094
 
 

 ##########
 File path: superset/connectors/druid/models.py
 ##########
 @@ -102,9 +103,12 @@ class DruidCluster(Model, AuditMixinNullable, ImportMixin):
     broker_endpoint = Column(String(255), default='druid/v2')
     metadata_last_refreshed = Column(DateTime)
     cache_timeout = Column(Integer)
+    broker_user = Column(String(255))
+    broker_pass = Column(EncryptedType(String(255), conf.get('SECRET_KEY')))
 
     export_fields = ('cluster_name', 'broker_host', 'broker_port',
-                     'broker_endpoint', 'cache_timeout')
+                     'broker_endpoint', 'cache_timeout', 'broker_user',
+                     'broker_pass')
 
 Review comment:
   no. the encryption thing swizzles it like the other 'secrets'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org