You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@baremaps.apache.org by "bchapuis (via GitHub)" <gi...@apache.org> on 2025/02/01 00:01:15 UTC

[PR] Improve the NOTICE file for the binary distribution [incubator-baremaps]

bchapuis opened a new pull request, #940:
URL: https://github.com/apache/incubator-baremaps/pull/940

   Following the discussion on JIRA regarding the NOTICE file for the binary distribution, this PR removes the notices-binary directory and concat all the notices in a single NOTICE-BINARY file at the root of the project. This file is renamed NOTICE and placed at the root of the binary distribution with maven assembly.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improve the NOTICE file for the binary distribution [incubator-baremaps]

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.

bchapuis merged PR #940:
URL: https://github.com/apache/incubator-baremaps/pull/940


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improve the NOTICE file for the binary distribution [incubator-baremaps]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.

sonarqubecloud[bot] commented on PR #940:
URL: https://github.com/apache/incubator-baremaps/pull/940#issuecomment-2628591769

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=940) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=940&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=940&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_baremaps&pullRequest=940&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=940&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=940&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=940)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improve the NOTICE file for the binary distribution [incubator-baremaps]

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.

bchapuis commented on PR #940:
URL: https://github.com/apache/incubator-baremaps/pull/940#issuecomment-2628594444

   @CalvinKirs I hope you are doing well. Do these changes suits you to address the licensing concerns raised in rc2? Thanks for your help.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improve the NOTICE file for the binary distribution [incubator-baremaps]

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.

bchapuis commented on PR #940:
URL: https://github.com/apache/incubator-baremaps/pull/940#issuecomment-2628887772

   @CalvinKirs For the source distribution, cleaning up the NOTICE files and keeping only the meaningful parts is realistic, as we have a good understanding of the source code. However, doing the same for the binary distribution and its dependencies is much more challenging since it's difficult to control what actually goes into the JAR files. I'm concerned that removing something important could have legal implications. To be safe, I decided to concatenate all the NOTICE files for the binary distribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org