You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/30 19:28:47 UTC

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #4037: Fix most benchmark query regressions

andygrove commented on code in PR #4037:
URL: https://github.com/apache/arrow-datafusion/pull/4037#discussion_r1008914877


##########
benchmarks/src/tpch.rs:
##########
@@ -38,12 +40,17 @@ pub const TPCH_TABLES: &[&str] = &[
     "part", "supplier", "partsupp", "customer", "orders", "lineitem", "nation", "region",
 ];
 
+fn decimal_type(_p: u8, _s: u8) -> DataType {
+    // TODO use decimal_type(p, s) once Decimal is fully supported
+    // https://github.com/apache/arrow-datafusion/issues/3523
+    DataType::Float64
+}

Review Comment:
   When we're ready to try decimal again, we just need to update this one function



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org