[jira] [Commented] (KAFKA-2358) Cluster collection returning methods should never return null

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033836#comment-16033836 ] 

ASF GitHub Bot commented on KAFKA-2358:
---------------------------------------

GitHub user guozhangwang opened a pull request:

    https://github.com/apache/kafka/pull/3200

    MINOR: Add upgrade notes for KAFKA-2358

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guozhangwang/kafka KMinor-KAFKA-2358-upgrade-notes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3200.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3200
    
----
commit 13394329c03eee647d1d194972b10108666ed6e1
Author: Guozhang Wang <wa...@gmail.com>
Date:   2017-06-01T22:40:02Z

    upgrade notes for KAFKA-2358

----


> Cluster collection returning methods should never return null
> -------------------------------------------------------------
>
>                 Key: KAFKA-2358
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2358
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.9.0.0
>            Reporter: Stevo Slavic
>            Assignee: Stevo Slavic
>            Priority: Minor
>             Fix For: 0.11.0.0
>
>
> {{KafkaConsumer.partitionsFor}} method by it's signature returns a {{List<PartitionInfo>}}. Problem is that in case (metadata for) topic does not exist, current implementation will return null, which is considered a bad practice - instead of null it should return empty list.
> Root cause is that the Cluster collection returning methods are returning null.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)