[GitHub] [maven] MartinKanters commented on a change in pull request #677: [MNG-7390] Allow selecting modules outside the cwd into the reactor using --projects.

[GitBox <gi...@apache.org>]

MartinKanters commented on a change in pull request #677:
URL: https://github.com/apache/maven/pull/677#discussion_r810266037



##########
File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##########
@@ -138,8 +138,10 @@ public DefaultGraphBuilder( BuildResumptionDataRepository buildResumptionDataRep
     {
         ProjectDependencyGraph projectDependencyGraph = new DefaultProjectDependencyGraph( projects );
         List<MavenProject> activeProjects = projectDependencyGraph.getSortedProjects();
+        List<MavenProject> allSortedProjects = projectDependencyGraph.getSortedProjects();

Review comment:
       It starts like that, but `activeProjects` is constantly being overwritten each step in the reactor the activeProjects list. This is a pattern I don't like (I prefer immutable variables). It's one of the things I fixed in the bigger refactoring.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org