You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "chenBright (via GitHub)" <gi...@apache.org> on 2023/02/20 16:12:19 UTC
[PR] revert consul naming service (brpc)
chenBright opened a new pull request, #2129:
URL: https://github.com/apache/brpc/pull/2129
### What problem does this PR solve?
Issue Number: #2123
Problem Summary:
ConsulNamingService其实不是PeriodicNamingService，不是简单的轮询，而是[长轮询](https://brpc.incubator.apache.org/zh/docs/client/basics/#consulservice-name)，每次rpc成功后，立即发起下一次长轮询。只有失败了，才会sleep。
[Blocking Queries](https://developer.hashicorp.com/consul/api-docs/features/blocking)：
> Many endpoints in Consul support a feature known as "blocking queries". A blocking query is used to wait for a potential change using long polling.
### What is changed and the side effects?
Changed:
回退#2123 ConsulNamingService的改动
Side effects:
- Performance effects(性能影响):
- Breaking backward compatibility(向后兼容性):
---
### Check List:
- Please make sure your changes are compilable(请确保你的更改可以通过编译).
- When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
- Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] revert consul naming service (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #2129:
URL: https://github.com/apache/brpc/pull/2129#issuecomment-1437832648
CI重试之后还是失败，看起来和代码改动无关
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] revert consul naming service (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #2129:
URL: https://github.com/apache/brpc/pull/2129#issuecomment-1438081272
master修复了CI失败，可以rebase一下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] revert consul naming service (brpc)
Posted by "chenBright (via GitHub)" <gi...@apache.org>.
chenBright commented on PR #2129:
URL: https://github.com/apache/brpc/pull/2129#issuecomment-1440101993
> > CI是不是还有问题？我本地跑是可以过的，但是CI跑了几次，都是core在这个地方。
> > > [ RUN ] NamingServiceTest.consul_with_backup_file
> > > temp_file_e34bq7
> > > Segmentation fault (core dumped)
> > > corefile=./core.brpc_naming_ser.12853 prog=brpc_naming_service_unittest
> > > ./run_tests.sh: 42: gdb: not found
>
> 看上去似乎和改动有关
是的，现在好了。git commit不太整洁，合的时候需要square一下。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] revert consul naming service (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm merged PR #2129:
URL: https://github.com/apache/brpc/pull/2129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] revert consul naming service (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #2129:
URL: https://github.com/apache/brpc/pull/2129#issuecomment-1439378211
> CI是不是还有问题？我本地跑是可以过的，但是CI跑了几次，都是core在这个地方。
>
> > [ RUN ] NamingServiceTest.consul_with_backup_file
> > temp_file_e34bq7
> > Segmentation fault (core dumped)
> > corefile=./core.brpc_naming_ser.12853 prog=brpc_naming_service_unittest
> > ./run_tests.sh: 42: gdb: not found
看上去似乎和改动有关
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] revert consul naming service (brpc)
Posted by "chenBright (via GitHub)" <gi...@apache.org>.
chenBright commented on PR #2129:
URL: https://github.com/apache/brpc/pull/2129#issuecomment-1438350373
CI是不是还有问题，我本地跑是可以过的，但是CI跑了几次，都是core在这个地方。
> [ RUN ] NamingServiceTest.consul_with_backup_file
temp_file_e34bq7
Segmentation fault (core dumped)
corefile=./core.brpc_naming_ser.12853 prog=brpc_naming_service_unittest
./run_tests.sh: 42: gdb: not found
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org