[GitHub] [lucene] gsmiller commented on pull request #597: LUCENE-10372: Performance of TaxoFacets in Nightly benchmark decreased, revert LUCENE-10350

[GitBox <gi...@apache.org>]

gsmiller commented on pull request #597:
URL: https://github.com/apache/lucene/pull/597#issuecomment-1010061194


   Let's not jump to reverting this change too hastily. It would be nice to reproduce the regressions locally and try to understand what's going on a little more. It seems very counter-intuitive to me that this change would cause any sort of regression. Note that #585 also got merged yesterday so it's possible that could be related to the regression as well.
   
   I also notice that, while some tasks are getting consistently slower (so there's definitely something going on), one improved. Maybe this will help us track down what's going on.
   
   **Regressed Tasks**
   - https://home.apache.org/~mikemccand/lucenebench/BrowseRandomLabelTaxoFacets.html
   - https://home.apache.org/~mikemccand/lucenebench/BrowseDateTaxoFacets.html
   - https://home.apache.org/~mikemccand/lucenebench/BrowseDayOfYearTaxoFacets.html
   
   **Improved Task**
   - https://home.apache.org/~mikemccand/lucenebench/BrowseMonthTaxoFacets.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org