You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "mhenc (via GitHub)" <gi...@apache.org> on 2023/02/02 12:33:08 UTC

[GitHub] [airflow] mhenc opened a new issue, #29311: AIP-44 Migrate TaskInstance.refresh_from_db to Internal API

mhenc opened a new issue, #29311:
URL: https://github.com/apache/airflow/issues/29311

   https://github.com/apache/airflow/blob/main/airflow/models/taskinstance.py#L770
   
   Note it is used in multiple places. The place needed by AIP-44
   https://github.com/apache/airflow/blob/main/airflow/jobs/local_task_job.py#L234


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] AIP-44 Migrate TaskInstance.refresh_from_db to Internal API [airflow]

Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on issue #29311:
URL: https://github.com/apache/airflow/issues/29311#issuecomment-1851305789

   Hi @mhenc I see you've marked this done. Is it done? Is work on it in progress?  Are there any particular challenges in this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] AIP-44 Migrate TaskInstance.refresh_from_db to Internal API [airflow]

Posted by "mhenc (via GitHub)" <gi...@apache.org>.
mhenc commented on issue #29311:
URL: https://github.com/apache/airflow/issues/29311#issuecomment-1852026403

   Yes, it is done. 
   If you take a look at 
   https://github.com/apache/airflow/blob/main/airflow/models/taskinstance.py#L464C28-L464C40 
   then  you can see that method
   `TaskInstance.get_task_instance`
   is already migrated
   https://github.com/apache/airflow/blob/main/airflow/api_internal/endpoints/rpc_api_endpoint.py#L82


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] AIP-44 Migrate TaskInstance.refresh_from_db to Internal API [airflow]

Posted by "mhenc (via GitHub)" <gi...@apache.org>.
mhenc closed issue #29311: AIP-44 Migrate TaskInstance.refresh_from_db to Internal API
URL: https://github.com/apache/airflow/issues/29311


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org