[GitHub] [flink] dawidwys commented on a change in pull request #8781: [FLINK-12874][table-common] Improve the semantics of zero length strings

[GitBox <gi...@apache.org>]

dawidwys commented on a change in pull request #8781: [FLINK-12874][table-common] Improve the semantics of zero length strings
URL: https://github.com/apache/flink/pull/8781#discussion_r295162812
 
 

 ##########
 File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/BinaryType.java
 ##########
 @@ -91,9 +92,11 @@ private BinaryType(int length, boolean isNullable) {
 	 * For consistent behavior, the same logic applies to binary strings.
 	 *
 	 * <p>This method enables this special kind of binary string.
+	 *
+	 * <p>Zero-length binary strings have no serializable string representation.
 	 */
 	public static BinaryType ofEmptyLiteral() {
-		return new BinaryType(EMPTY_LITERAL_LENGTH, false);
+		return new BinaryType(EMPTY_LITERAL_LENGTH, true);
 
 Review comment:
   Is it possible to create a nullable empty literal? I think empty string literals by the contract of our API will always be non null.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services