You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2010/11/23 20:23:14 UTC

[jira] Created: (WICKET-3187) StringResourceStream has null lastModified time

StringResourceStream has null lastModified time
-----------------------------------------------

                 Key: WICKET-3187
                 URL: https://issues.apache.org/jira/browse/WICKET-3187
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.5-M3
            Reporter: Martin Grigorov


>From users@ :

...it fails with a NPE in (ResourceStreamResource.java line 72), because it seems is always expecting that any IResourceStream implementation set the lastModifiedTime in the underlying stream before calling dataNeedsToBeWritten....

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-3187) StringResourceStream has null lastModified time

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-3187.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-M4
         Assignee: Martin Grigorov

Fixed with r1038292.
Now every instance of AbstractStringResourceStream has Time.now() as initial value for lastModified at construction time.

> StringResourceStream has null lastModified time
> -----------------------------------------------
>
>                 Key: WICKET-3187
>                 URL: https://issues.apache.org/jira/browse/WICKET-3187
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-M3
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>             Fix For: 1.5-M4
>
>
> From users@ :
> ...it fails with a NPE in (ResourceStreamResource.java line 72), because it seems is always expecting that any IResourceStream implementation set the lastModifiedTime in the underlying stream before calling dataNeedsToBeWritten....

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3187) StringResourceStream has null lastModified time

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998215#comment-12998215 ] 

Martin Grigorov commented on WICKET-3187:
-----------------------------------------

Additionally TextTemplateDecorator looks to be broken by design ?! It delegates all setter methods to the decorated template but all getters use 'this', i.e. the decorator.

> StringResourceStream has null lastModified time
> -----------------------------------------------
>
>                 Key: WICKET-3187
>                 URL: https://issues.apache.org/jira/browse/WICKET-3187
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-M3
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>             Fix For: 1.5-RC1
>
>         Attachments: WICKET-3187.patch
>
>
> From users@ :
> ...it fails with a NPE in (ResourceStreamResource.java line 72), because it seems is always expecting that any IResourceStream implementation set the lastModifiedTime in the underlying stream before calling dataNeedsToBeWritten....

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (WICKET-3187) StringResourceStream has null lastModified time

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-3187.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-RC3

Fixed with r1073630.
I'll create a separate ticket for the getters problem.
Thanks Frank!

> StringResourceStream has null lastModified time
> -----------------------------------------------
>
>                 Key: WICKET-3187
>                 URL: https://issues.apache.org/jira/browse/WICKET-3187
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-M3
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>             Fix For: 1.5-RC3, 1.5-RC1
>
>         Attachments: WICKET-3187.patch
>
>
> From users@ :
> ...it fails with a NPE in (ResourceStreamResource.java line 72), because it seems is always expecting that any IResourceStream implementation set the lastModifiedTime in the underlying stream before calling dataNeedsToBeWritten....

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WICKET-3187) StringResourceStream has null lastModified time

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov updated WICKET-3187:
------------------------------------

    Comment: was deleted

(was: Additionally TextTemplateDecorator looks to be broken by design ?! It delegates all setter methods to the decorated template but all getters use 'this', i.e. the decorator.)

> StringResourceStream has null lastModified time
> -----------------------------------------------
>
>                 Key: WICKET-3187
>                 URL: https://issues.apache.org/jira/browse/WICKET-3187
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-M3
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>             Fix For: 1.5-RC1, 1.5-RC3
>
>         Attachments: WICKET-3187.patch
>
>
> From users@ :
> ...it fails with a NPE in (ResourceStreamResource.java line 72), because it seems is always expecting that any IResourceStream implementation set the lastModifiedTime in the underlying stream before calling dataNeedsToBeWritten....

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Reopened: (WICKET-3187) StringResourceStream has null lastModified time

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov reopened WICKET-3187:
-------------------------------------


> StringResourceStream has null lastModified time
> -----------------------------------------------
>
>                 Key: WICKET-3187
>                 URL: https://issues.apache.org/jira/browse/WICKET-3187
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-M3
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>             Fix For: 1.5-RC1
>
>         Attachments: WICKET-3187.patch
>
>
> From users@ :
> ...it fails with a NPE in (ResourceStreamResource.java line 72), because it seems is always expecting that any IResourceStream implementation set the lastModifiedTime in the underlying stream before calling dataNeedsToBeWritten....

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (WICKET-3187) StringResourceStream has null lastModified time

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998228#comment-12998228 ] 

Martin Grigorov edited comment on WICKET-3187 at 2/23/11 8:16 AM:
------------------------------------------------------------------

Fixed with r1073630.
Thanks Frank!

      was (Author: mgrigorov):
    Fixed with r1073630.
I'll create a separate ticket for the getters problem.
Thanks Frank!
  
> StringResourceStream has null lastModified time
> -----------------------------------------------
>
>                 Key: WICKET-3187
>                 URL: https://issues.apache.org/jira/browse/WICKET-3187
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-M3
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>             Fix For: 1.5-RC1, 1.5-RC3
>
>         Attachments: WICKET-3187.patch
>
>
> From users@ :
> ...it fails with a NPE in (ResourceStreamResource.java line 72), because it seems is always expecting that any IResourceStream implementation set the lastModifiedTime in the underlying stream before calling dataNeedsToBeWritten....

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WICKET-3187) StringResourceStream has null lastModified time

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-3187:
---------------------------------------

    Attachment: WICKET-3187.patch

The fix for this issue causes the CssTemplate to fail on construction time. See the attached unit test.

> StringResourceStream has null lastModified time
> -----------------------------------------------
>
>                 Key: WICKET-3187
>                 URL: https://issues.apache.org/jira/browse/WICKET-3187
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-M3
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>             Fix For: 1.5-RC1
>
>         Attachments: WICKET-3187.patch
>
>
> From users@ :
> ...it fails with a NPE in (ResourceStreamResource.java line 72), because it seems is always expecting that any IResourceStream implementation set the lastModifiedTime in the underlying stream before calling dataNeedsToBeWritten....

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira