You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/19 12:47:29 UTC
[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request, #9112: [Bug][Storage-vectorized] fix code dump on outer join with not nullable column
BiteTheDDDDt opened a new pull request, #9112:
URL: https://github.com/apache/incubator-doris/pull/9112
# Proposed changes
Issue Number: close #9105
1. make `not nullable predicate column` match `nullable column`
2. forbid empty block push down to storage engine, remove code with `not mem reuse` condition.
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
3. Has unit tests been added: (Yes/No/No Need)
4. Has document been added or modified: (Yes/No/No Need)
5. Does it need to update dependencies: (Yes/No)
6. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangbo commented on a diff in pull request #9112: [Bug][Storage-vectorized] fix code dump on outer join with not nullable column
Posted by GitBox <gi...@apache.org>.
wangbo commented on code in PR #9112:
URL: https://github.com/apache/incubator-doris/pull/9112#discussion_r853824372
##########
be/src/vec/columns/predicate_column.h:
##########
@@ -23,6 +23,7 @@
#include "vec/columns/column.h"
#include "vec/columns/column_decimal.h"
#include "vec/columns/column_impl.h"
+#include "vec/columns/column_nullable.h"
Review Comment:
remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9112: [Bug][Storage-vectorized] fix code dump on outer join with not nullable column
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9112:
URL: https://github.com/apache/incubator-doris/pull/9112#issuecomment-1103505219
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9112: [Bug][Storage-vectorized] fix code dump on outer join with not nullable column
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9112:
URL: https://github.com/apache/incubator-doris/pull/9112#issuecomment-1103505232
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9112: [Bug][Storage-vectorized] fix code dump on outer join with not nullable column
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9112:
URL: https://github.com/apache/incubator-doris/pull/9112#issuecomment-1103793462
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangbo commented on a diff in pull request #9112: [Bug][Storage-vectorized] fix code dump on outer join with not nullable column
Posted by GitBox <gi...@apache.org>.
wangbo commented on code in PR #9112:
URL: https://github.com/apache/incubator-doris/pull/9112#discussion_r853695757
##########
be/src/vec/columns/predicate_column.h:
##########
@@ -348,6 +349,13 @@ class PredicateColumnType final : public COWHelper<IColumn, PredicateColumnType<
}
Status filter_by_selector(const uint16_t* sel, size_t sel_size, IColumn* col_ptr) override {
+ if (col_ptr->is_nullable()) {
Review Comment:
Move this Nullable judgement to block.
PredicateColumn should not feel this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a diff in pull request #9112: [Bug][Storage-vectorized] fix code dump on outer join with not nullable column
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #9112:
URL: https://github.com/apache/incubator-doris/pull/9112#discussion_r853828698
##########
be/src/vec/columns/predicate_column.h:
##########
@@ -23,6 +23,7 @@
#include "vec/columns/column.h"
#include "vec/columns/column_decimal.h"
#include "vec/columns/column_impl.h"
+#include "vec/columns/column_nullable.h"
Review Comment:
> remove this
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangbo commented on a diff in pull request #9112: [Bug][Storage-vectorized] fix code dump on outer join with not nullable column
Posted by GitBox <gi...@apache.org>.
wangbo commented on code in PR #9112:
URL: https://github.com/apache/incubator-doris/pull/9112#discussion_r853695757
##########
be/src/vec/columns/predicate_column.h:
##########
@@ -348,6 +349,13 @@ class PredicateColumnType final : public COWHelper<IColumn, PredicateColumnType<
}
Status filter_by_selector(const uint16_t* sel, size_t sel_size, IColumn* col_ptr) override {
+ if (col_ptr->is_nullable()) {
Review Comment:
Move this Nullable judgement to block.
PredicateColumn should not this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee merged pull request #9112: [Bug][Storage-vectorized] fix code dump on outer join with not nullable column
Posted by GitBox <gi...@apache.org>.
HappenLee merged PR #9112:
URL: https://github.com/apache/incubator-doris/pull/9112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org