You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by dhalperi <gi...@git.apache.org> on 2017/01/25 18:48:15 UTC

[GitHub] beam pull request #1846: [BEAM-246] re-enable Checkstyle by default

GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/1846

    [BEAM-246] re-enable Checkstyle by default

    This adds 50%+ overhead to a clean build (with testing disabled), but
    per dev@ discussion is a huge usability win for contributors and
    committers alike.
    
    https://lists.apache.org/thread.html/CAA8k_FKafuon8GEA3CXwR2MZh2kAXEFZQK=BgX5tk2fZJebrag@mail.gmail.com

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam checkstyle-default

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1846.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1846
    
----
commit 0d0eb9bf3fa5b3facf403d486787c579c2e82228
Author: Dan Halperin <dh...@google.com>
Date:   2017-01-24T21:52:06Z

    [BEAM-246] re-enable Checkstyle by default
    
    This adds 50%+ overhead to a clean build (with testing disabled), but
    per dev@ discussion is a huge usability win for contributors and
    committers alike.
    
    https://lists.apache.org/thread.html/CAA8k_FKafuon8GEA3CXwR2MZh2kAXEFZQK=BgX5tk2fZJebrag@mail.gmail.com

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #1846: [BEAM-246] re-enable Checkstyle by default

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/1846


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---