svn commit: r1311097 - in /lucene/dev/trunk/lucene: core/src/java/org/apache/lucene/analysis/tokenattributes/OffsetAttributeImpl.java test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamTestCase.java

[mi...@apache.org]

Author: mikemccand
Date: Sun Apr  8 20:44:58 2012
New Revision: 1311097

URL: http://svn.apache.org/viewvc?rev=1311097&view=rev
Log:
add TODOs

Modified:
    lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/analysis/tokenattributes/OffsetAttributeImpl.java
    lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamTestCase.java

Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/analysis/tokenattributes/OffsetAttributeImpl.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/analysis/tokenattributes/OffsetAttributeImpl.java?rev=1311097&r1=1311096&r2=1311097&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/analysis/tokenattributes/OffsetAttributeImpl.java (original)
+++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/analysis/tokenattributes/OffsetAttributeImpl.java Sun Apr  8 20:44:58 2012
@@ -40,10 +40,18 @@ public class OffsetAttributeImpl extends
   /** Set the starting and ending offset.
     @see #startOffset() and #endOffset()*/
   public void setOffset(int startOffset, int endOffset) {
+
+    // TODO: we could assert that this is set-once, ie,
+    // current values are -1?  Very few token filters should
+    // change offsets once set by the tokenizer... and
+    // tokenizer should call clearAtts before re-using
+    // OffsetAtt
+
     // TODO: check that these are valid!  IE, each should be
     // >= 0, and endOffset should be >= startOffset.
     // Problem is this could "break" existing
     // tokenizers/filters.
+
     this.startOffset = startOffset;
     this.endOffset = endOffset;
   }
@@ -59,6 +67,8 @@ public class OffsetAttributeImpl extends
 
   @Override
   public void clear() {
+    // TODO: we could use -1 as default here?  Then we can
+    // assert in setOffset...
     startOffset = 0;
     endOffset = 0;
   }

Modified: lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamTestCase.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamTestCase.java?rev=1311097&r1=1311096&r2=1311097&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamTestCase.java (original)
+++ lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamTestCase.java Sun Apr  8 20:44:58 2012
@@ -439,6 +439,8 @@ public abstract class BaseTokenStreamTes
       try {
         checkAnalysisConsistency(random, a, useCharFilter, text);
       } catch (Throwable t) {
+        // TODO: really we should pass a random seed to
+        // checkAnalysisConsistency then print it here too:
         System.err.println("TEST FAIL: useCharFilter=" + useCharFilter + " text='" + escape(text) + "'");
         Rethrow.rethrow(t);
       }