You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by mc...@apache.org on 2008/03/21 22:30:07 UTC
svn commit: r639857 - in
/incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl:
SCADomainEventServiceProxyImpl.java SCADomainProxyImpl.java
SCANodeFactoryImpl.java SCANodeImpl.java SCANodeUtil.java
Author: mcombellack
Date: Fri Mar 21 14:30:05 2008
New Revision: 639857
URL: http://svn.apache.org/viewvc?rev=639857&view=rev
Log:
Minor JavaDoc updates and spelling corrections
Modified:
incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCADomainEventServiceProxyImpl.java
incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCADomainProxyImpl.java
incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCANodeFactoryImpl.java
incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCANodeImpl.java
incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCANodeUtil.java
Modified: incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCADomainEventServiceProxyImpl.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCADomainEventServiceProxyImpl.java?rev=639857&r1=639856&r2=639857&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCADomainEventServiceProxyImpl.java (original)
+++ incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCADomainEventServiceProxyImpl.java Fri Mar 21 14:30:05 2008
@@ -52,7 +52,7 @@
public void registerNode(String nodeURI, String nodeURL, Externalizable nodeManagerService) throws DomainException {
- // a rety loop is included on node registration in case the node
+ // a retry loop is included on node registration in case the node
// comes up before the domain it is registering with
for (int i =0; i < retryCount; i++){
try {
Modified: incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCADomainProxyImpl.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCADomainProxyImpl.java?rev=639857&r1=639856&r2=639857&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCADomainProxyImpl.java (original)
+++ incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCADomainProxyImpl.java Fri Mar 21 14:30:05 2008
@@ -63,7 +63,7 @@
/**
- * A local representation of the sca domain running on a single node
+ * A local representation of the SCA Domain running on a single node
*
* @version $Rev$ $Date$
*/
@@ -108,7 +108,7 @@
*/
protected void init() throws DomainException {
try {
- // check where domain uris are urls, they will be used to configure various
+ // check where domain URIs are URLs, they will be used to configure various
// endpoints if they are
URI tmpURI;
try {
@@ -220,7 +220,7 @@
int domainPort = domainURI.getPort();
// override any domain URLs in node.composite and replace with the
- // domain url provided on start up
+ // domain URL provided on start up
for ( Component component : composite.getComponents()){
for (ComponentReference reference : component.getReferences() ){
for (Binding binding : reference.getBindings() ) {
@@ -350,7 +350,7 @@
try {
// create the node manager endpoint
- // TODO - we really need to pass in a callable reference
+ // TODO - we really need to pass in a CallableReference
URI nodeURI = new URI(node.getURI());
String nodeHost = nodeURI.getHost();
Modified: incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCANodeFactoryImpl.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCANodeFactoryImpl.java?rev=639857&r1=639856&r2=639857&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCANodeFactoryImpl.java (original)
+++ incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCANodeFactoryImpl.java Fri Mar 21 14:30:05 2008
@@ -64,7 +64,7 @@
* don't provide this information
* @param domainURI the URI of the domain that the node belongs to. This URI is
* used to locate the domain manager on the network
- * @param logicalNodeURI the uri of the node to be used in situations where more than one node
+ * @param logicalNodeURI the URI of the node to be used in situations where more than one node
* are grouped together for failover or load balancing scenarios. The logicalNodeURI
* will typically identify the logical node where requests are sent
* @return a new SCA node.
@@ -77,7 +77,7 @@
* Creates a new SCA node. Many physical nodes may share the same logical URL in load balancing
* and failover scenarios where each node in the group runs the same contribution and
* active composites. Also allows a class loaded to b specified. This is the
- * classloader that will be used to load the management application used by the
+ * ClassLoader that will be used to load the management application used by the
* node to talk to the domain
*
* @param physicalNodeURI the URI of the node, this URI is used to provide the default
@@ -85,12 +85,12 @@
* don't provide this information
* @param domainURI the URI of the domain that the node belongs to. This URI is
* used to locate the domain manager on the network
- * @param logicalNodeURI the uri of the node to be used in situations where more than one node
+ * @param logicalNodeURI the URI of the node to be used in situations where more than one node
* are grouped together for failover or load balancing scenarios. The logicalNodeURI
* will typically identify the logical node where requests are sent. If null is provided
* no logicalNodeURI is set.
* @param classLoader the class loader to use by default when loading contributions. If null is provided
- * the classloader the dervied automatically.
+ * the ClassLoader the derived automatically.
* @return a new SCA node.
*/
public SCANode createSCANode(String physicalNodeURI, String domainURI, String logicalNodeURI, ClassLoader classLoader) throws NodeException {
Modified: incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCANodeImpl.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCANodeImpl.java?rev=639857&r1=639856&r2=639857&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCANodeImpl.java (original)
+++ incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCANodeImpl.java Fri Mar 21 14:30:05 2008
@@ -83,7 +83,7 @@
private String logicalNodeURI;
private String domainURI;
- // The tuscany runtime that does the hard work
+ // The Tuscany runtime that does the hard work
private ReallySmallRuntime nodeRuntime;
// the top level components in this node. A subset of the the domain level composite
@@ -114,9 +114,9 @@
* Creates a node connected to a wider domain. To find its place in the domain
* node and domain identifiers must be provided.
*
- * @param physicalNodeUri - if this is a url it is assumed that this will be used as root url for management components, e.g. http://localhost:8082
+ * @param physicalNodeUri - if this is a URL it is assumed that this will be used as root URL for management components, e.g. http://localhost:8082
* @param domainUri - identifies what host and port the domain service is running on, e.g. http://localhost:8081
- * @param logicalNodeURI the uri of the node group. This is the enpoint URI of the head of the
+ * @param logicalNodeURI the URI of the node group. This is the endpoint URI of the head of the
* group of nodes. For example, in load balancing scenarios this will be the loaded balancer itself
* @throws ActivationException
*/
@@ -132,9 +132,9 @@
* Creates a node connected to a wider domain and allows a classpath to be specified.
* To find its place in the domain node and domain identifiers must be provided.
*
- * @param physicalNodeUri - if this is a url it is assumed that this will be used as root url for management components, e.g. http://localhost:8082
+ * @param physicalNodeUri - if this is a URL it is assumed that this will be used as root URL for management components, e.g. http://localhost:8082
* @param domainUri - identifies what host and port the domain service is running on, e.g. http://localhost:8081
- * @param logicalNodeURI the uri of the node group. This is the enpoint URI of the head of the
+ * @param logicalNodeURI the URI of the node group. This is the endpoint URI of the head of the
* group of nodes. For example, in load balancing scenarios this will be the loaded balancer itself
* @param cl - the ClassLoader to use for loading system resources for the node
* @throws ActivationException
@@ -164,7 +164,7 @@
socket.close();
}
- // check whether node uri is an absolute url,
+ // check whether node URI is an absolute URL,
try {
URI tmpURI = new URI(nodeURI);
nodeURL = tmpURI.toURL();
@@ -610,7 +610,7 @@
/**
* Configure the default HTTP port for this node.
- * The motivation here is to set the default binding on the servlet container
+ * The motivation here is to set the default binding on the Servlet container
* based on whatever information is available. In particular if no Node URL is
* provided then one of the ports from the first composite is used so that
* some recognizable default is provided for any bindings that are specified
Modified: incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCANodeUtil.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCANodeUtil.java?rev=639857&r1=639856&r2=639857&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCANodeUtil.java (original)
+++ incubator/tuscany/java/sca/modules/node-impl/src/main/java/org/apache/tuscany/sca/node/impl/SCANodeUtil.java Fri Mar 21 14:30:05 2008
@@ -126,17 +126,17 @@
}
*/
/**
- * A rather ugly method to find and fix the url of the service, assuming that there
+ * A rather ugly method to find and fix the URL of the service, assuming that there
* is one.
*
* we can't get this out of a service reference
* the component itself doesn't know how to get it
* the binding can't to do it automatically as it's not the sca binding
*
- * TODO - This would be better done by passing out a serializable reference to service discovery
+ * TODO - This would be better done by passing out a Serializable reference to service discovery
* but this doesn't work yet
*
- * @return node manager url
+ * @return node manager URL
*/
/*
public static void fixUpNodeServiceUrls(List<Component> nodeComponents, URL nodeUrlString)
@@ -175,7 +175,7 @@
*/
/**
- * For node management services that use the http(s) protocol then use the node url as the enpoint
+ * For node management services that use the HTTP(S) protocol then use the node URL as the enpoint
* if it has been specified otherwise find a port that isn't in use and make sure the domain name
* is the real domain name
*
@@ -242,7 +242,7 @@
/**
* For node services that have to talk to the domain fix up the reference URL using the
- * provided domain url if it has been provided
+ * provided domain URL if it has been provided
*
* @param nodeComponents
* @param domainUrlString
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org